Fragment that establishes new BFC knows it's BFC offset in parent space

Fragment that establishes new BFC knows it's BFC offset in parent space

List of changes:
- If a fragment establishes new BFC then we can collapse its margin and
  assume that it's BFC offset is known. We can't use
  fragment->BfcOffset() in this case because each BFC has it's own BFC
  coordinates.
- Revert lines that changed the usage of BFC offset to 'unified' offset
- s/CalculateRelativeOffset/CalculateLogicalOffset/g
- other minor clean up

BUG=635619
TESTS=NGBlockLayoutAlgorithmTest::CollapsingMarginsCase5

Review-Url: https://codereview.chromium.org/2679343002
Cr-Commit-Position: refs/heads/master@{#449223}
Committed: https://chromium.googlesource.com/chromium/src/+/bbea7637c1d6adafff338cd00b0de80d7a97cf69

[Gleb Lanbin, 2017-02-07 22:03:24]

Patchset #1 (id:1) has been deleted

[Gleb Lanbin, 2017-02-07 22:04:02]

glebl@chromium.org changed reviewers:
+ ikilpatrick@chromium.org

[Gleb Lanbin, 2017-02-07 22:04:07]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 22:05:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 23:19:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 23:19:44]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Gleb Lanbin, 2017-02-07 23:46:52]

Patchset #1 (id:20001) has been deleted

[Gleb Lanbin, 2017-02-07 23:46:58]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 23:48:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 01:36:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 01:36:34]

Dry run: This issue passed the CQ dry run.

[Gleb Lanbin, 2017-02-08 17:16:15]

Description was changed from

==========
Fragment that establishes new BFC knows it's BFC offset in parent space

List of changes:
- If a fragment establishes new BFC then we can collapse its margin and
  assume that it's BFC offset is known. We can't use
  fragment->BfcOffset() in this case because each BFC has it's own BFC
  coordinates.
- Revert lines that changed the usage of BFC offset to 'unified' offset
- s/CalculateRelativeOffset/CalculateLogicalOffset/g
- other minor clean up

BUG=635619
TESTS=NGBlockLayoutAlgorithmTest::CollapsingMarginsCase5
==========

to

==========
Fragment that establishes new BFC knows it's BFC offset in parent space

List of changes:
- If a fragment establishes new BFC then we can collapse its margin and
  assume that it's BFC offset is known. We can't use
  fragment->BfcOffset() in this case because each BFC has it's own BFC
  coordinates.
- Revert lines that changed the usage of BFC offset to 'unified' offset
- s/CalculateRelativeOffset/CalculateLogicalOffset/g
- other minor clean up

BUG=635619
TESTS=NGBlockLayoutAlgorithmTest::CollapsingMarginsCase5
==========

[Gleb Lanbin, 2017-02-08 17:16:15]

glebl@chromium.org changed reviewers:
+ cbiesinger@chromium.org

[cbiesinger, 2017-02-08 23:00:40]

I'll let Ian review this, he knows this code better

[ikilpatrick, 2017-02-09 01:57:25]

lgtm sorry for slow review.

[Gleb Lanbin, 2017-02-09 02:47:43]

The CQ bit was checked by glebl@chromium.org

[commit-bot: I haz the power, 2017-02-09 02:48:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 06:18:24]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486608463194960,
"parent_rev": "3b76fcf9516aed2d90a61ae035cfdf2b2a18e08c", "commit_rev":
"bbea7637c1d6adafff338cd00b0de80d7a97cf69"}

[commit-bot: I haz the power, 2017-02-09 06:19:12]

Description was changed from

==========
Fragment that establishes new BFC knows it's BFC offset in parent space

List of changes:
- If a fragment establishes new BFC then we can collapse its margin and
  assume that it's BFC offset is known. We can't use
  fragment->BfcOffset() in this case because each BFC has it's own BFC
  coordinates.
- Revert lines that changed the usage of BFC offset to 'unified' offset
- s/CalculateRelativeOffset/CalculateLogicalOffset/g
- other minor clean up

BUG=635619
TESTS=NGBlockLayoutAlgorithmTest::CollapsingMarginsCase5
==========

to

==========
Fragment that establishes new BFC knows it's BFC offset in parent space

List of changes:
- If a fragment establishes new BFC then we can collapse its margin and
  assume that it's BFC offset is known. We can't use
  fragment->BfcOffset() in this case because each BFC has it's own BFC
  coordinates.
- Revert lines that changed the usage of BFC offset to 'unified' offset
- s/CalculateRelativeOffset/CalculateLogicalOffset/g
- other minor clean up

BUG=635619
TESTS=NGBlockLayoutAlgorithmTest::CollapsingMarginsCase5

Review-Url: https://codereview.chromium.org/2679343002
Cr-Commit-Position: refs/heads/master@{#449223}
Committed:
https://chromium.googlesource.com/chromium/src/+/bbea7637c1d6adafff338cd00b0d...
==========

[commit-bot: I haz the power, 2017-02-09 06:19:13]

Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/bbea7637c1d6adafff338cd00b0d...