Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: ui/gfx/animation/slide_animation.cc

Issue 2679333002: [ash-md] Remove the number of animators used for the Shelf animations. (Closed)
Patch Set: Addressed comments from patch set 4. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/animation/slide_animation.h ('k') | ui/gfx/animation/slide_animation_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/animation/slide_animation.cc
diff --git a/ui/gfx/animation/slide_animation.cc b/ui/gfx/animation/slide_animation.cc
index 780e8ec8b0fa70593b13042edc5b228484e067d2..eb4d24e2c71165d76f08496f35de774d3d75089b 100644
--- a/ui/gfx/animation/slide_animation.cc
+++ b/ui/gfx/animation/slide_animation.cc
@@ -67,6 +67,8 @@ void SlideAnimation::Hide() {
// Make sure we actually have something to do.
if (slide_duration_ == 0) {
+ // TODO(bruthig): Investigate if this should really be animating to 0.0, I
+ // think it should be animating to 1.0.
AnimateToState(0.0); // Skip to the end of the animation.
return;
} else if (value_current_ == value_end_) {
« no previous file with comments | « ui/gfx/animation/slide_animation.h ('k') | ui/gfx/animation/slide_animation_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698