Remove content/browser dependency on WebFontRenderStyle.

Remove content/browser dependency on WebFontRenderStyle.

It's only called by the renderer, but was put in a utilities file in content/common that was shared with other methods that are called from the browser. Fix this by splitting the common method from the child-only ones.

BUG=248653
Review-Url: https://codereview.chromium.org/2679323006
Cr-Commit-Position: refs/heads/master@{#449672}
Committed: https://chromium.googlesource.com/chromium/src/+/cc96c42adf22da9c109014c85c6fb11642962e73

[jam, 2017-02-10 06:51:53]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 06:52:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 06:56:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 06:56:54]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jam, 2017-02-10 07:00:54]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 07:01:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 07:05:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 07:05:51]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jam, 2017-02-10 07:25:38]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 07:26:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-02-10 07:36:40]

Patchset #2 (id:20001) has been deleted

[jam, 2017-02-10 07:36:47]

Patchset #1 (id:1) has been deleted

[jam, 2017-02-10 08:02:48]

Description was changed from

==========
Remove content/browser dependency on WebFontRenderStyle.

BUG=248653
==========

to

==========
Remove content/browser dependency on WebFontRenderStyle.

It's only called by the renderer, but was put in a utilities file in
content/common that was shared with other methods that are called from the
browser. Fix this by splitting the common method from the child-only ones.

BUG=248653
==========

[commit-bot: I haz the power, 2017-02-10 10:56:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 10:56:44]

Dry run: This issue passed the CQ dry run.

[jam, 2017-02-10 15:50:25]

jam@chromium.org changed reviewers:
+ scottmg@chromium.org, thakis@chromium.org

[jam, 2017-02-10 15:50:26]

Nico: third_party/WebKit/Source/platform/BUILD.gn
Scott: the rest

[scottmg, 2017-02-10 16:07:48]

lgtm

[Nico, 2017-02-10 16:27:29]

On 2017/02/10 16:07:48, scottmg wrote:
> lgtm

Lgtm

[jam, 2017-02-10 16:37:15]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2017-02-10 16:37:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 16:43:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 16:43:39]

Failed to apply patch for third_party/WebKit/Source/platform/BUILD.gn:
While running git apply --index -p1;
  error: patch failed: third_party/WebKit/Source/platform/BUILD.gn:30
  error: third_party/WebKit/Source/platform/BUILD.gn: patch does not apply

Patch:       third_party/WebKit/Source/platform/BUILD.gn
Index: third_party/WebKit/Source/platform/BUILD.gn
diff --git a/third_party/WebKit/Source/platform/BUILD.gn
b/third_party/WebKit/Source/platform/BUILD.gn
index
d053681f6c8d8d3d638c03bb7da8d3604b676690..8dfcd79c7e9f7ee9ea64f9c8ba873709e30f4f1f
100644
--- a/third_party/WebKit/Source/platform/BUILD.gn
+++ b/third_party/WebKit/Source/platform/BUILD.gn
@@ -30,12 +30,7 @@ component("blink_common") {
     "exported/WebCString.cpp",
     "exported/WebCoalescedInputEvent.cpp",
     "exported/WebString.cpp",
-    "exported/linux/WebFontRenderStyle.cpp",
   ]
-  if (is_android) {
-    set_sources_assignment_filter([])
-    sources += [ "exported/linux/WebFontRenderStyle.cpp" ]
-  }
 
   defines = [
     "BLINK_COMMON_IMPLEMENTATION=1",
@@ -590,6 +585,7 @@ component("platform") {
     "exported/WebURLResponse.cpp",
     "exported/WrappedResourceRequest.h",
     "exported/WrappedResourceResponse.h",
+    "exported/linux/WebFontRenderStyle.cpp",
     "feature_policy/FeaturePolicy.cpp",
     "feature_policy/FeaturePolicy.h",
     "fonts/AcceptLanguagesResolver.cpp",
@@ -1406,6 +1402,11 @@ component("platform") {
     "weborigin/URLSecurityOriginMap.h",
   ]
 
+  if (is_android) {
+    set_sources_assignment_filter([])
+    sources += [ "exported/linux/WebFontRenderStyle.cpp" ]
+  }
+
   sources -= blink_platform_neon_files
   sources -= blink_platform_msa_files
   sources -= blink_platform_sse_files

[jam, 2017-02-10 16:52:25]

The CQ bit was checked by jam@chromium.org

[jam, 2017-02-10 16:52:26]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org,
scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/2679323006/#ps60001
(title: "merge")

[commit-bot: I haz the power, 2017-02-10 16:53:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 18:50:24]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486745545609750,
"parent_rev": "6a80ba877b1e6a77ce84c610a4f2627f468a7bab", "commit_rev":
"cc96c42adf22da9c109014c85c6fb11642962e73"}

[commit-bot: I haz the power, 2017-02-10 18:50:57]

Description was changed from

==========
Remove content/browser dependency on WebFontRenderStyle.

It's only called by the renderer, but was put in a utilities file in
content/common that was shared with other methods that are called from the
browser. Fix this by splitting the common method from the child-only ones.

BUG=248653
==========

to

==========
Remove content/browser dependency on WebFontRenderStyle.

It's only called by the renderer, but was put in a utilities file in
content/common that was shared with other methods that are called from the
browser. Fix this by splitting the common method from the child-only ones.

BUG=248653

Review-Url: https://codereview.chromium.org/2679323006
Cr-Commit-Position: refs/heads/master@{#449672}
Committed:
https://chromium.googlesource.com/chromium/src/+/cc96c42adf22da9c109014c85c6f...
==========

[commit-bot: I haz the power, 2017-02-10 18:50:58]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/cc96c42adf22da9c109014c85c6f...

[jam, 2017-02-10 19:18:26]

Patchset #3 (id:70001) has been deleted