Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2679323005: Update callsites to new SkColorSpace API, delete legacy flag (Closed)

Created:
3 years, 10 months ago by msarett
Modified:
3 years, 10 months ago
CC:
ajuma+watch_chromium.org, ajuma+watch-canvas_chromium.org, blink-reviews, blink-reviews-html_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), haraken, jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update callsites to new SkColorSpace API, delete legacy flag NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2679323005 Cr-Commit-Position: refs/heads/master@{#449757} Committed: https://chromium.googlesource.com/chromium/src/+/29c855766ef0dfcbfd559a233806166769cfee1b

Patch Set 1 #

Total comments: 2

Patch Set 2 : Formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -46 lines) Patch
M skia/config/SkUserConfig.h View 1 chunk +0 lines, -4 lines 0 comments Download
M skia/public/interfaces/bitmap_skbitmap_struct_traits.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmap.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp View 7 chunks +11 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/html/ImageData.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ColorSpace.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp View 3 chunks +6 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/png/PNGImageDecoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/color_space.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/icc_profile_unittest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 31 (18 generated)
msarett1
Nothing too interesting going on here... skia/ fmalita@, reed@ third_party/WebKit/Source/core fmalita@ third_party/WebKit/Source/modules/ esprehn@ third_party/WebKit/Source/platform fmalita@ ...
3 years, 10 months ago (2017-02-09 14:48:17 UTC) #2
f(malita)
lgtm
3 years, 10 months ago (2017-02-09 15:03:42 UTC) #5
msw
ui/gfx lgtm with a nit https://codereview.chromium.org/2679323005/diff/1/ui/gfx/icc_profile_unittest.cc File ui/gfx/icc_profile_unittest.cc (right): https://codereview.chromium.org/2679323005/diff/1/ui/gfx/icc_profile_unittest.cc#newcode25 ui/gfx/icc_profile_unittest.cc:25: SkColorSpace::MakeSRGB(); nit: fits on ...
3 years, 10 months ago (2017-02-09 16:46:44 UTC) #6
msarett1
+mlamouri@ for modules review https://codereview.chromium.org/2679323005/diff/1/ui/gfx/icc_profile_unittest.cc File ui/gfx/icc_profile_unittest.cc (right): https://codereview.chromium.org/2679323005/diff/1/ui/gfx/icc_profile_unittest.cc#newcode25 ui/gfx/icc_profile_unittest.cc:25: SkColorSpace::MakeSRGB(); On 2017/02/09 16:46:44, msw ...
3 years, 10 months ago (2017-02-09 17:16:00 UTC) #8
mlamouri (slow - plz ping)
modules/ lgtm
3 years, 10 months ago (2017-02-09 17:38:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2679323005/20001
3 years, 10 months ago (2017-02-09 21:25:11 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/360933)
3 years, 10 months ago (2017-02-09 21:34:14 UTC) #17
msarett1
Oops, still need a security review. dcheng@ can you take a look?
3 years, 10 months ago (2017-02-09 21:40:12 UTC) #19
msarett1
Ping :), still needs a trivial security review
3 years, 10 months ago (2017-02-10 18:58:33 UTC) #21
meacer
Security lgtm
3 years, 10 months ago (2017-02-10 19:06:03 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2679323005/20001
3 years, 10 months ago (2017-02-10 19:09:02 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2679323005/20001
3 years, 10 months ago (2017-02-10 22:08:42 UTC) #28
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 22:17:41 UTC) #31
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/29c855766ef0dfcbfd559a233806...

Powered by Google App Engine
This is Rietveld 408576698