Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Issue 2679323004: Android: Restructure geolocation folder structure (Closed)

Created:
3 years, 10 months ago by Peter Wen
Modified:
3 years, 10 months ago
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android: Restructure geolocation folder structure Enables android studio targets to include whole source directories. Also align with the rest of java folder structure in chromium. Includes git cl format changes. BUG=620034 Review-Url: https://codereview.chromium.org/2679323004 Cr-Commit-Position: refs/heads/master@{#449945} Committed: https://chromium.googlesource.com/chromium/src/+/ab58303a76a0ced3a777aca31af15eb5d6e9185a

Patch Set 1 #

Patch Set 2 : Update deps #

Messages

Total messages: 21 (12 generated)
Peter Wen
Hi Michael, PTAL, this is a plain restructuring for the java directory and separates test ...
3 years, 10 months ago (2017-02-08 17:02:22 UTC) #2
Michael van Ouwerkerk
lgtm
3 years, 10 months ago (2017-02-08 17:05:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2679323004/1
3 years, 10 months ago (2017-02-08 18:30:35 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/386209)
3 years, 10 months ago (2017-02-08 20:06:00 UTC) #7
Peter Wen
+torne@ for android_webview/javatests/DEPS +mariakhomenko@ for chrome/android/javatests/DEPS
3 years, 10 months ago (2017-02-08 21:41:37 UTC) #9
Torne
android_webview LGTM
3 years, 10 months ago (2017-02-09 13:47:07 UTC) #14
Maria
lgtm
3 years, 10 months ago (2017-02-09 23:50:22 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2679323004/20001
3 years, 10 months ago (2017-02-13 13:00:07 UTC) #18
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 14:03:44 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ab58303a76a0ced3a777aca31af1...

Powered by Google App Engine
This is Rietveld 408576698