Implemented IA2::setSelection and related methods on text fields in Views.

Implemented IA2::setSelection and related methods on text fields in Views.

Entering grade 2 Braille should now work with Jaws when in the address bar.
BUG=645596
R=dmazzoni@chromium.org, msw@chromium.org
CC=aleventhal@google.com
TESTED=unit test, NVDA Python console > focus.IAccessibleTextObject.setSelection(...)

Review-Url: https://codereview.chromium.org/2679313003
Cr-Commit-Position: refs/heads/master@{#449143}
Committed: https://chromium.googlesource.com/chromium/src/+/1d4fdc1a0b9e9839a1b23498ca2791864669147a

[dmazzoni, 2017-02-08 00:41:14]

lgtm

https://codereview.chromium.org/2679313003/diff/1/ui/accessibility/platform/a...
File ui/accessibility/platform/ax_platform_node_win_unittest.cc (right):

https://codereview.chromium.org/2679313003/diff/1/ui/accessibility/platform/a...
ui/accessibility/platform/ax_platform_node_win_unittest.cc:118: EXPECT_EQ(S_OK,
root_obj->get_accName(SELF, name.Receive()));
I think I made this an assert and not an expect
because if this line fails, name will be null
and the next line of code might crash rather than
return the empty string. If I'm wrong and it
works fine even if get_accName returns E_FAIL then
changing it to EXPECT is okay.

[chromium-reviews, 2017-02-08 16:41:18]

ui/accessibility/platform/ax_platform_node_win_unittest.cc:118:
> EXPECT_EQ(S_OK, root_obj->get_accName(SELF, name.Receive()));
> I think I made this an assert and not an expect
> because if this line fails, name will be null
> and the next line of code might crash rather than
> return the empty string.


Yes, you are right. I got carried away because in 
BrowserAccessibilityWin_Unittests I used EXPECT_EQ and for the string 
equivalence check I used EXPECT_STREQ which won't crash.
I changed all tests with BSTRs in this file to use EXPECT_STREQ as well. 
This won't require the creation of a base::string16 object.

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[nektarios, 2017-02-08 17:24:27]

Description was changed from

==========
Implemented IA2::setSelection and related methods on text fields in Views.

Entering grade 2 Braille should now work with Jaws when in the address bar.
BUG=645596
R=dmazzoni@chromium.org
CC=aleventhal@google.com
TESTED=unit test, NVDA Python console >
focus.IAccessibleTextObject.setSelection(...)
==========

to

==========
Implemented IA2::setSelection and related methods on text fields in Views.

Entering grade 2 Braille should now work with Jaws when in the address bar.
BUG=645596
R=dmazzoni@chromium.org, msw@chromium.org
CC=aleventhal@google.com
TESTED=unit test, NVDA Python console >
focus.IAccessibleTextObject.setSelection(...)
==========

[nektarios, 2017-02-08 17:24:27]

nektar@chromium.org changed reviewers:
+ msw@chromium.org

[nektarios, 2017-02-08 17:25:08]

@msw
Please review changes to ui/views/controls/text_field/text_field.cc

[nektarios, 2017-02-08 20:58:11]

nektar@chromium.org changed reviewers:
+ oshima@chromium.org

[nektarios, 2017-02-08 20:59:40]

@oshima
Please review changes to ui/views/controls/text_field

[msw, 2017-02-08 22:11:40]

ui/views/controls/textfield/textfield.cc lgtm with a q

https://codereview.chromium.org/2679313003/diff/20001/ui/views/controls/textf...
File ui/views/controls/textfield/textfield.cc (right):

https://codereview.chromium.org/2679313003/diff/20001/ui/views/controls/textf...
ui/views/controls/textfield/textfield.cc:903: // TODO(nektar): Check that the
focus_node_id matches the ID of this node.
q: can you address this now or file a bug and follow up soon?

[nektarios, 2017-02-08 22:17:36]

> ui/views/controls/textfield/textfield.cc:903: // TODO(nektar): Check that the
focus_node_id matches the ID of this node.
> q: can you address this now or file a bug and follow up soon?

I'll keep the existing bug open and address this immediately in a followup
patch.
I didn't want to do this in this patch without asking for another LGTM from
dmazzoni, hence a followup patch.

[nektarios, 2017-02-08 22:17:42]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2017-02-08 22:17:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2679313003/#ps20001
(title: "Made |SetTextSelection| return a value.")

[commit-bot: I haz the power, 2017-02-08 22:18:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 23:50:33]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486592262141180,
"parent_rev": "cdda024585a567ff0f9600bef01e0553e4b2f12e", "commit_rev":
"1d4fdc1a0b9e9839a1b23498ca2791864669147a"}

[commit-bot: I haz the power, 2017-02-08 23:51:08]

Description was changed from

==========
Implemented IA2::setSelection and related methods on text fields in Views.

Entering grade 2 Braille should now work with Jaws when in the address bar.
BUG=645596
R=dmazzoni@chromium.org, msw@chromium.org
CC=aleventhal@google.com
TESTED=unit test, NVDA Python console >
focus.IAccessibleTextObject.setSelection(...)
==========

to

==========
Implemented IA2::setSelection and related methods on text fields in Views.

Entering grade 2 Braille should now work with Jaws when in the address bar.
BUG=645596
R=dmazzoni@chromium.org, msw@chromium.org
CC=aleventhal@google.com
TESTED=unit test, NVDA Python console >
focus.IAccessibleTextObject.setSelection(...)

Review-Url: https://codereview.chromium.org/2679313003
Cr-Commit-Position: refs/heads/master@{#449143}
Committed:
https://chromium.googlesource.com/chromium/src/+/1d4fdc1a0b9e9839a1b23498ca27...
==========

[commit-bot: I haz the power, 2017-02-08 23:51:09]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1d4fdc1a0b9e9839a1b23498ca27...