Chromium Code Reviews
Description[css-grid] Clamp the number of auto repeat tracks in all cases
In #446646 we added clamping of auto repetitions so that they respected
kGridMaxTracks. The problem is that we were doing it only if the number of
auto repeat tracks was >kGridMaxtracks. When the amount of auto-repeat
tracks was exactly kGridMaxTracks there was no clamping and thus, the sole
existence of one non auto repeat track was enough to surpass the limits.
Apart from that there were other non-handled cases, like having more than
kGridMaxTracks (both non auto repeat and auto repeat tracks) or having
a <track-list> in the auto repeat syntax with more than kGridMaxTracks
tracks.
BUG=687941
Review-Url: https://codereview.chromium.org/2670363003
Cr-Commit-Position: refs/heads/master@{#448602}
(cherry picked from commit bccd320563864b14db492b37954bac2d9d63d548)
Review-Url: https://codereview.chromium.org/2679303005 .
Cr-Commit-Position: refs/branch-heads/2987@{#402}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed: https://chromium.googlesource.com/chromium/src/+/29c4b6656c5884a8541483f2fa7bce4eb5575c23
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
|||||||||||||||||||||||||||||||||||||