Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2679303005: [css-grid] Clamp the number of auto repeat tracks in all cases (Closed)

Created:
3 years, 10 months ago by svillar
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[css-grid] Clamp the number of auto repeat tracks in all cases In #446646 we added clamping of auto repetitions so that they respected kGridMaxTracks. The problem is that we were doing it only if the number of auto repeat tracks was >kGridMaxtracks. When the amount of auto-repeat tracks was exactly kGridMaxTracks there was no clamping and thus, the sole existence of one non auto repeat track was enough to surpass the limits. Apart from that there were other non-handled cases, like having more than kGridMaxTracks (both non auto repeat and auto repeat tracks) or having a <track-list> in the auto repeat syntax with more than kGridMaxTracks tracks. BUG=687941 Review-Url: https://codereview.chromium.org/2670363003 Cr-Commit-Position: refs/heads/master@{#448602} (cherry picked from commit bccd320563864b14db492b37954bac2d9d63d548) Review-Url: https://codereview.chromium.org/2679303005 . Cr-Commit-Position: refs/branch-heads/2987@{#402} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/29c4b6656c5884a8541483f2fa7bce4eb5575c23

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+405 lines, -53 lines) Patch
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-auto-repeat-huge-grid.html View 2 chunks +376 lines, -46 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 3 chunks +27 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
svillar
3 years, 10 months ago (2017-02-09 10:55:57 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
29c4b6656c5884a8541483f2fa7bce4eb5575c23.

Powered by Google App Engine
This is Rietveld 408576698