Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2679303003: Reland of land: [Parse] ParseInfo owns the parsing Zone. (Closed)

Created:
3 years, 10 months ago by Michael Hablich
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of land: [Parse] ParseInfo owns the parsing Zone. (patchset #1 id:1 of https://codereview.chromium.org/2683733002/ ) Reason for revert: False alarm, bot hiccup Original issue's description: > Revert of Reland: [Parse] ParseInfo owns the parsing Zone. (patchset #7 id:140001 of https://codereview.chromium.org/2632123006/ ) > > Reason for revert: > Speculative revert because of revert needed for https://codereview.chromium.org/2632123006 > > Original issue's description: > > Reland: [Parse] ParseInfo owns the parsing Zone. > > > > Moves ownership of the parsing Zone to ParseInfo with a shared_ptr. This is > > in preperation for enabling background compilation jobs for inner functions > > share the AST in the outer-function's parse zone memory (read-only), with the > > and zone being released when all compilation jobs have completed. > > > > BUG=v8:5203, v8:5215 > > > > Review-Url: https://codereview.chromium.org/2632123006 > > Cr-Original-Commit-Position: refs/heads/master@{#42993} > > Committed: https://chromium.googlesource.com/v8/v8/+/14fb337200d5da09c77438ddd40bea935b1dc823 > > Review-Url: https://codereview.chromium.org/2632123006 > > Cr-Commit-Position: refs/heads/master@{#42996} > > Committed: https://chromium.googlesource.com/v8/v8/+/9e7d5a6065470ca03411d4c8dbc61d1be5c3f84a > > TBR=marja@chromium.org,mstarzinger@chromium.org,ahaas@chromium.org,verwaest@chromium.org,rmcilroy@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:5203, v8:5215 > > Review-Url: https://codereview.chromium.org/2683733002 > Cr-Commit-Position: refs/heads/master@{#43008} > Committed: https://chromium.googlesource.com/v8/v8/+/9fe08ec067051c5b46e694568bd01c6dba44cc4d TBR=marja@chromium.org,mstarzinger@chromium.org,ahaas@chromium.org,verwaest@chromium.org,rmcilroy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5203, v8:5215 Review-Url: https://codereview.chromium.org/2679303003 Cr-Commit-Position: refs/heads/master@{#43015} Committed: https://chromium.googlesource.com/v8/v8/+/395dfc073e6b52468c4d5fd52c08d835e5539ab7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -302 lines) Patch
M src/asmjs/asm-wasm-builder.cc View 2 chunks +14 lines, -14 lines 0 comments Download
M src/background-parsing-task.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/background-parsing-task.cc View 2 chunks +1 line, -4 lines 0 comments Download
M src/compiler.cc View 9 chunks +9 lines, -17 lines 0 comments Download
M src/compiler-dispatcher/compiler-dispatcher-job.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler-dispatcher/compiler-dispatcher-job.cc View 6 chunks +4 lines, -8 lines 0 comments Download
M src/compiler/js-inlining.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/compiler/pipeline.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M src/crankshaft/hydrogen.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/debug/debug-scopes.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/parsing/parse-info.h View 4 chunks +13 lines, -5 lines 0 comments Download
M src/parsing/parse-info.cc View 3 chunks +13 lines, -5 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/asmjs/test-asm-typer.cc View 12 chunks +30 lines, -28 lines 0 comments Download
M test/cctest/compiler/function-tester.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-linkage.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-loop-assignment-analysis.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-run-bytecode-graph-builder.cc View 131 chunks +70 lines, -133 lines 0 comments Download
M test/cctest/parsing/test-preparser.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M test/cctest/test-parsing.cc View 24 chunks +24 lines, -40 lines 0 comments Download
M test/fuzzer/parser.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/unittests/compiler-dispatcher/compiler-dispatcher-unittest.cc View 4 chunks +3 lines, -7 lines 0 comments Download
M test/unittests/compiler-dispatcher/optimizing-compile-dispatcher-unittest.cc View 3 chunks +1 line, -4 lines 0 comments Download
M tools/parser-shell.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Hablich
Created Reland of land: [Parse] ParseInfo owns the parsing Zone.
3 years, 10 months ago (2017-02-07 20:46:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2679303003/1
3 years, 10 months ago (2017-02-07 20:46:32 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 20:46:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/395dfc073e6b52468c4d5fd52c08d835e55...

Powered by Google App Engine
This is Rietveld 408576698