Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 26793004: Add support for catching rendere crashes in drt (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
===================================================================
--- tools/testing/dart/test_runner.dart (revision 28442)
+++ tools/testing/dart/test_runner.dart (working copy)
@@ -817,6 +817,10 @@
return super.canRunDependendCommands && !didFail(null);
}
+ bool get hasCrashed {
+ return super.hasCrashed || _rendereCrashed;
kustermann 2013/10/10 08:55:22 If you commit this change as it is now, it will li
ricow1 2013/10/10 09:26:50 They are red - very red. There are no tests outsi
+ }
+
Expectation _getOutcome() {
if (_failedBecauseOfMissingXDisplay) {
return Expectation.FAIL;
@@ -852,6 +856,14 @@
return false;
}
+ bool get _rendereCrashed {
kustermann 2013/10/10 08:55:22 _rendereCrashed => _rendererCrashed
ricow1 2013/10/10 09:26:50 Done.
+ var stdoutLines = decodeUtf8(super.stdout).split("\n");
kustermann 2013/10/10 08:55:22 Is this really in stdout (and not in stderr)?
ricow1 2013/10/10 09:26:50 It is in both
+ for (String line in stdoutLines) {
+ if (line.startsWith('#CRASHED - rendere')) return true;
+ }
kustermann 2013/10/10 08:55:22 I think it would be faster and equally good, to ju
ricow1 2013/10/10 09:26:50 Done.
+ return false;
+ }
+
bool get _failedBecauseOfUnexpectedDRTOutput {
/*
* The output of content shell is different for pixel tests than for
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698