Chromium Code Reviews| Index: tools/testing/dart/test_runner.dart |
| =================================================================== |
| --- tools/testing/dart/test_runner.dart (revision 28442) |
| +++ tools/testing/dart/test_runner.dart (working copy) |
| @@ -817,6 +817,10 @@ |
| return super.canRunDependendCommands && !didFail(null); |
| } |
| + bool get hasCrashed { |
| + return super.hasCrashed || _rendereCrashed; |
|
kustermann
2013/10/10 08:55:22
If you commit this change as it is now, it will li
ricow1
2013/10/10 09:26:50
They are red - very red.
There are no tests outsi
|
| + } |
| + |
| Expectation _getOutcome() { |
| if (_failedBecauseOfMissingXDisplay) { |
| return Expectation.FAIL; |
| @@ -852,6 +856,14 @@ |
| return false; |
| } |
| + bool get _rendereCrashed { |
|
kustermann
2013/10/10 08:55:22
_rendereCrashed => _rendererCrashed
ricow1
2013/10/10 09:26:50
Done.
|
| + var stdoutLines = decodeUtf8(super.stdout).split("\n"); |
|
kustermann
2013/10/10 08:55:22
Is this really in stdout (and not in stderr)?
ricow1
2013/10/10 09:26:50
It is in both
|
| + for (String line in stdoutLines) { |
| + if (line.startsWith('#CRASHED - rendere')) return true; |
| + } |
|
kustermann
2013/10/10 08:55:22
I think it would be faster and equally good, to ju
ricow1
2013/10/10 09:26:50
Done.
|
| + return false; |
| + } |
| + |
| bool get _failedBecauseOfUnexpectedDRTOutput { |
| /* |
| * The output of content shell is different for pixel tests than for |