Add support for catching rendere crashes in drt

tools/testing/dart/test_runner.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for executing tests.
  *
  * This module includes:
  * - Managing parallel execution of tests, including timeout checks.
  * - Evaluating the output of each test as pass/fail/crash/timeout.
@@ skipping 799 matching lines @@
   }
 
   bool get successful => canRunDependendCommands;
 
   bool get canRunDependendCommands {
     // We cannot rely on the exit code of content_shell as a method to determine
     // if we were successful or not.
     return super.canRunDependendCommands && !didFail(null);
   }
 
+  bool get hasCrashed {
+    return super.hasCrashed || _rendereCrashed;

[kustermann, 2013/10/10 08:55:22]

If you commit this change as it is now, it will likely make our bots red.
You have to run it locally, and make status file changes from
  [ $runtime == drt ]
  abc_test: Fail
to
  [ $runtime == drt ]
  abc_test: Crash

[ricow1, 2013/10/10 09:26:50]

They are red - very red. 
There are no tests outside cc tests that are marked as crashing on the VM, i.e.,
there should be nothing else crashing like this! (except those for issue 13808
and 13952, these are already marked genericly as crashing on compiler==none)

+  }
+
   Expectation _getOutcome() {
     if (_failedBecauseOfMissingXDisplay) {
       return Expectation.FAIL;
     }
 
     if (command.expectedOutputFile != null) {
       // We are either doing a pixel test or a layout test with content shell
       if (_failedBecauseOfUnexpectedDRTOutput) {
         return Expectation.FAIL;
       }
@@ skipping 15 matching lines @@
       // TODO(kustermann,ricow): Issue: 7564
       // This seems to happen quite frequently, we need to figure out why.
       if (line.contains(MESSAGE_CANNOT_OPEN_DISPLAY) ||
           line.contains(MESSAGE_FAILED_TO_RUN_COMMAND)) {
         return true;
       }
     }
     return false;
   }
 
+  bool get _rendereCrashed {

[kustermann, 2013/10/10 08:55:22]

_rendereCrashed => _rendererCrashed

[ricow1, 2013/10/10 09:26:50]

Done.

+    var stdoutLines = decodeUtf8(super.stdout).split("\n");

[kustermann, 2013/10/10 08:55:22]

Is this really in stdout (and not in stderr)?

[ricow1, 2013/10/10 09:26:50]

It is in both

+    for (String line in stdoutLines) {
+      if (line.startsWith('#CRASHED - rendere')) return true;
+    }

[kustermann, 2013/10/10 08:55:22]

I think it would be faster and equally good, to just say:

bool get _rendererCrashed => decodeUtf8(stdout).contains("#CRASHED - render")

[ricow1, 2013/10/10 09:26:50]

Done.

+    return false;
+  }
+
   bool get _failedBecauseOfUnexpectedDRTOutput {
     /*
      * The output of content shell is different for pixel tests than for
      * layout tests.
      *
      * On a pixel test, the DRT output has the following format
      *     ......
      *     ......
      *     Content-Length: ...\n
      *     <*png data>
@@ skipping 1502 matching lines @@
     }
   }
 
   void eventAllTestsDone() {
     for (var listener in _eventListener) {
       listener.allDone();
     }
     _allDone();
   }
 }