Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2679293002: Fix TaskScheduler initialization in remoting processes. (Closed)

Created:
3 years, 10 months ago by fdoray
Modified:
3 years, 10 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix TaskScheduler initialization in remoting processes. TaskScheduler was not initialized in ios::AppRuntime because of an inverted condition. TaskScheduler was never shutdown in remoting processes. BUG=659191 Review-Url: https://codereview.chromium.org/2679293002 Cr-Commit-Position: refs/heads/master@{#449043} Committed: https://chromium.googlesource.com/chromium/src/+/a1c82ce5d3aa4bb7401cc533a3538b8db6808d38

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M remoting/client/ios/app_runtime.cc View 1 chunk +1 line, -1 line 1 comment Download
M remoting/client/jni/chromoting_jni_runtime.cc View 1 chunk +4 lines, -0 lines 1 comment Download
M remoting/host/it2me/it2me_native_messaging_host_main.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M remoting/host/setup/me2me_native_messaging_host_main.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
fdoray
PTAL https://codereview.chromium.org/2679293002/diff/1/remoting/client/ios/app_runtime.cc File remoting/client/ios/app_runtime.cc (right): https://codereview.chromium.org/2679293002/diff/1/remoting/client/ios/app_runtime.cc#newcode53 remoting/client/ios/app_runtime.cc:53: // TODO(nicholss): Shutdown the app. Since multiple AppRuntimes ...
3 years, 10 months ago (2017-02-08 13:22:44 UTC) #7
Sergey Ulanov
LGTM. Thanks!
3 years, 10 months ago (2017-02-08 18:34:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2679293002/1
3 years, 10 months ago (2017-02-08 18:38:30 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 18:46:17 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a1c82ce5d3aa4bb7401cc533a353...

Powered by Google App Engine
This is Rietveld 408576698