Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 2679233002: Change hover element to scrollbar's parent when hit test contains scrollbar (Closed)

Created:
3 years, 10 months ago by bokan
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Change hover element to scrollbar's parent when hit test contains scrollbar This issue is caused by remove hit test element in |Document::updateHoverActiveState| when hit test contains scrollbar. Instead we should replace the hit test element to be scrollbar's parent when hitting a scrollbar. BUG=686678 Review-Url: https://codereview.chromium.org/2668133003 Cr-Commit-Position: refs/heads/master@{#448078} (cherry picked from commit 4d68b33ea8398044d86aa76353e6f7de6880bad6) Review-Url: https://codereview.chromium.org/2679233002 . Cr-Commit-Position: refs/branch-heads/2987@{#363} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/14233c89ca0484b7aa73a7a6d09b7e7155a338b9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -8 lines) Patch
M third_party/WebKit/Source/core/dom/Document.cpp View 2 chunks +15 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 2 chunks +87 lines, -1 line 0 comments Download
A third_party/WebKit/Source/web/tests/data/scrollbar-and-element-hover.html View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
bokan
3 years, 10 months ago (2017-02-07 18:47:03 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
14233c89ca0484b7aa73a7a6d09b7e7155a338b9.

Powered by Google App Engine
This is Rietveld 408576698