Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2679213002: Remove cachedTextBlob lookup in Font::getTextIntercepts (Closed)

Created:
3 years, 10 months ago by drott
Modified:
3 years, 10 months ago
Reviewers:
f(malita)
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove cachedTextBlob lookup in Font::getTextIntercepts This doesn't do anything since the callsite creates a new TextRunPaintInfo every time. BUG=689578 Review-Url: https://codereview.chromium.org/2679213002 Cr-Commit-Position: refs/heads/master@{#448874} Committed: https://chromium.googlesource.com/chromium/src/+/16f3d2401ca5d2e68d956507a86d57fb3b60d350

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M third_party/WebKit/Source/platform/fonts/Font.cpp View 1 chunk +1 line, -12 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
drott
3 years, 10 months ago (2017-02-07 18:23:11 UTC) #2
f(malita)
lgtm
3 years, 10 months ago (2017-02-07 18:51:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2679213002/1
3 years, 10 months ago (2017-02-07 22:43:16 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 02:50:53 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/16f3d2401ca5d2e68d956507a86d...

Powered by Google App Engine
This is Rietveld 408576698