Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects at most 10 tests.

BUG=639732
Review-Url: https://codereview.chromium.org/2679193002
Cr-Commit-Position: refs/heads/master@{#450718}
Committed: https://chromium.googlesource.com/chromium/src/+/047fc28e61cb62e44c07a5b89c86a44ae30f9b46

[zakerinasab, 2017-02-07 19:10:38]

Description was changed from

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects at most 10 tests.

BUG=639732
==========

to

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects at most 10 tests.

BUG=639732
==========

[zakerinasab, 2017-02-07 19:10:38]

zakerinasab@chromium.org changed reviewers:
+ junov@chromium.org

[Justin Novosad, 2017-02-09 20:37:19]

https://codereview.chromium.org/2679193002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-animated.html
(right):

https://codereview.chromium.org/2679193002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-animated.html:29:
createImageBitmap(img).then(t.step_func(function(image) {
I don't think step_func is needed here. Also, it results in nested step_funcs,
which is a bit weird.

https://codereview.chromium.org/2679193002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-hit-regions-accessibility-test.html
(right):

https://codereview.chromium.org/2679193002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-hit-regions-accessibility-test.html:49:
test(function(t) {
should use generate_tests here

[zakerinasab, 2017-02-13 17:06:10]

Comments addressed. New change list uploaded.

https://codereview.chromium.org/2679193002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-animated.html
(right):

https://codereview.chromium.org/2679193002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-animated.html:29:
createImageBitmap(img).then(t.step_func(function(image) {
On 2017/02/09 20:37:19, Justin Novosad wrote:
> I don't think step_func is needed here. Also, it results in nested step_funcs,
> which is a bit weird.

Done.

https://codereview.chromium.org/2679193002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-hit-regions-accessibility-test.html
(right):

https://codereview.chromium.org/2679193002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-hit-regions-accessibility-test.html:49:
test(function(t) {
On 2017/02/09 20:37:19, Justin Novosad wrote:
> should use generate_tests here

Done.

[Justin Novosad, 2017-02-14 21:16:32]

lgtm

[zakerinasab, 2017-02-15 14:53:25]

The CQ bit was checked by zakerinasab@chromium.org

[commit-bot: I haz the power, 2017-02-15 14:53:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 16:05:33]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487170405324430,
"parent_rev": "59a7ad896fbc906833b38120fc8776a368fe28d2", "commit_rev":
"047fc28e61cb62e44c07a5b89c86a44ae30f9b46"}

[commit-bot: I haz the power, 2017-02-15 16:06:07]

Description was changed from

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects at most 10 tests.

BUG=639732
==========

to

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects at most 10 tests.

BUG=639732

Review-Url: https://codereview.chromium.org/2679193002
Cr-Commit-Position: refs/heads/master@{#450718}
Committed:
https://chromium.googlesource.com/chromium/src/+/047fc28e61cb62e44c07a5b89c86...
==========

[commit-bot: I haz the power, 2017-02-15 16:06:08]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/047fc28e61cb62e44c07a5b89c86...