Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2679173006: [M57] GetThreatSeverity should handle the case of CheckResourceUrl. (Closed)

Created:
3 years, 10 months ago by vakh (use Gerrit instead)
Modified:
3 years, 10 months ago
Reviewers:
estark
CC:
chromium-reviews, Nathan Parker, Scott Hess - ex-Googler
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[M57] GetThreatSeverity should handle the case of CheckResourceUrl. Added the case statement and a unit test that forces a full hash match which causes this method to get executed. BUG=689672 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2680163002 Cr-Commit-Position: refs/heads/master@{#448885} (cherry picked from commit 4e2788493f4bef375b52e78e5a9ee38f2d92b191) Review-Url: https://codereview.chromium.org/2679173006 Cr-Commit-Position: refs/branch-heads/2987@{#420} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/840966737a17e664a34df6ebf816d534ece71d3e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -15 lines) Patch
M components/safe_browsing_db/v4_local_database_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/safe_browsing_db/v4_local_database_manager_unittest.cc View 9 chunks +57 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
estark
lgtm
3 years, 10 months ago (2017-02-09 22:55:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2679173006/1
3 years, 10 months ago (2017-02-09 22:56:13 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 22:58:07 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/840966737a17e664a34df6ebf816...

Powered by Google App Engine
This is Rietveld 408576698