Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2679173002: [builtins] fix String.prototype.indexOf with negative indices (Closed)

Created:
3 years, 10 months ago by Camillo Bruni
Modified:
3 years, 10 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] fix String.prototype.indexOf with negative indices BUG=689078 Review-Url: https://codereview.chromium.org/2679173002 Cr-Commit-Position: refs/heads/master@{#43016} Committed: https://chromium.googlesource.com/v8/v8/+/029a145fdb35061c0a1ae413532ca9dc62f4cce2

Patch Set 1 #

Patch Set 2 : fix accidental change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M src/builtins/builtins-string.cc View 2 chunks +1 line, -2 lines 0 comments Download
M test/mjsunit/string-indexof-1.js View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Camillo Bruni
PTAL
3 years, 10 months ago (2017-02-07 15:40:28 UTC) #2
Jakob Kummerow
lgtm
3 years, 10 months ago (2017-02-07 18:16:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2679173002/20001
3 years, 10 months ago (2017-02-07 21:04:01 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 21:31:08 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/029a145fdb35061c0a1ae413532ca9dc62f...

Powered by Google App Engine
This is Rietveld 408576698