Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
3 years, 10 months ago by v8-autoroll Modified:
3 years, 10 months ago Reviewers:
Michael Hablich, Dan Ehrenberg, vogelheim, Michael Achenbach CC:
chromium-reviews, gab, jam, shimazu, engedy Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdate V8 to version 5.8.140.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/cb98dac7..f51fbeda
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org
Review-Url: https://codereview.chromium.org/2679163002
Cr-Commit-Position: refs/heads/master@{#448643}
Committed: https://chromium.googlesource.com/chromium/src/+/7a9166c8f9c45e51678a94949593fa5c8b2d7419
Patch Set 1 #Messages
Total messages: 17 (5 generated)
The CQ bit was checked by v8-autoroll@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by v8-autoroll@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1486484110948620, "parent_rev":
"a0d282eee1b4e20cd10f0bfaef744a331b1967fa", "commit_rev":
"7a9166c8f9c45e51678a94949593fa5c8b2d7419"}
Message was sent while issue was closed.
Description was changed from ========== Update V8 to version 5.8.140. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cb98dac7..f51fbeda Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogel... ========== to ========== Update V8 to version 5.8.140. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cb98dac7..f51fbeda Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogel... Review-Url: https://codereview.chromium.org/2679163002 Cr-Commit-Position: refs/heads/master@{#448643} Committed: https://chromium.googlesource.com/chromium/src/+/7a9166c8f9c45e51678a94949593... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/7a9166c8f9c45e51678a94949593...
Message was sent while issue was closed.
Suspecting this roll to blow up the webkit layout tests in debug mode: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064%20%... Waiting for the chromium side bot: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty...
Message was sent while issue was closed.
Suspecting this roll to blow up the webkit layout tests in debug mode: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064%20%... Waiting for the chromium side bot: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty...
Message was sent while issue was closed.
Heads up Chromium sheriffs. The v8 upstream webkit debug bot is in a bad state since some commits in this roll: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064%20%... So far nothing else broke and the chromium bot is still running: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty... If it breaks in the same way (i.e. lots of timeouts), feel free to revert this roll and also the subsequent one with version 5.8.142 that already landed in the mean time. Rolling is already closed.
Message was sent while issue was closed.
Are you already bisecting/investigating?
Message was sent while issue was closed.
On 2017/02/07 19:21:22, Michael Hablich wrote: > Are you already bisecting/investigating? Nope, also not planning to...
Message was sent while issue was closed.
FYI: Speculative upstream reverts are rolling: https://codereview.chromium.org/2686643002/
Message was sent while issue was closed.
On 2017/02/07 20:19:55, Michael Achenbach wrote: > FYI: Speculative upstream reverts are rolling: > https://codereview.chromium.org/2686643002/ FYI: Chances seem to be high that V8 just has a broken upstream bot :( Chromium seems resilient to our problems... |
