Log into the user-data-dir instead of Chrome's bundle.

Log into the user-data-dir instead of Chrome's bundle.

Even for debug builds, Chrome should not write anywhere inside its bundle. This
behavior is explicitly forbidden by Apple. This invalidates the entire bundle,
particularly its code identity. Debug builds will now long into the user data
directory.

BUG=688959
Review-Url: https://codereview.chromium.org/2679133004
Cr-Commit-Position: refs/heads/master@{#451799}
Committed: https://chromium.googlesource.com/chromium/src/+/344ea468c3a47b782e5cd0a6d7f8eb704e158561

[Greg K, 2017-02-08 23:17:37]

The CQ bit was checked by kerrnel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 23:18:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 00:27:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 00:27:22]

Dry run: This issue passed the CQ dry run.

[Greg K, 2017-02-09 00:47:47]

kerrnel@chromium.org changed reviewers:
+ thakis@chromium.org

[Greg K, 2017-02-09 00:47:47]

PTAL.

Thanks,

Greg

[Nico, 2017-02-10 21:36:18]

lgtm

https://codereview.chromium.org/2679133004/diff/1/chrome/common/chrome_paths.cc
File chrome/common/chrome_paths.cc (right):

https://codereview.chromium.org/2679133004/diff/1/chrome/common/chrome_paths....
chrome/common/chrome_paths.cc:143: #ifdef NDEBUG
i wondered why we even make this differentiation and found (internal only,
sorry) https://b/853431 /
https://chrome-internal.googlesource.com/chrome/chrome-history/+/f4d4aae13fc9...

It sounds like we could probably just always use the user data dir

[Nico, 2017-02-10 21:49:48]

(and https://codereview.chromium.org/115868 suggests that nobody cares much
about where the log goes anyhow)

On Fri, Feb 10, 2017 at 4:36 PM, <thakis@chromium.org> wrote:

> lgtm
>
>
> https://codereview.chromium.org/2679133004/diff/1/chrome/
> common/chrome_paths.cc
> File chrome/common/chrome_paths.cc (right):
>
> https://codereview.chromium.org/2679133004/diff/1/chrome/
> common/chrome_paths.cc#newcode143
> chrome/common/chrome_paths.cc:143: #ifdef NDEBUG
> i wondered why we even make this differentiation and found (internal
> only, sorry) https://b/853431 /
> https://chrome-internal.googlesource.com/chrome/chrome-history/+/
> f4d4aae13fc97b2fad9d8ed471124a1def7c7609
>
> It sounds like we could probably just always use the user data dir
>
> https://codereview.chromium.org/2679133004/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Greg K, 2017-02-21 16:59:34]

The CQ bit was checked by kerrnel@chromium.org

[commit-bot: I haz the power, 2017-02-21 17:00:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 18:19:30]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487696374153510, "parent_rev":
"50549d69c7c12eb9058011dac35c6b7f351f51a1", "commit_rev":
"344ea468c3a47b782e5cd0a6d7f8eb704e158561"}

[commit-bot: I haz the power, 2017-02-21 18:20:04]

Description was changed from

==========
Log into the user-data-dir instead of Chrome's bundle.

Even for debug builds, Chrome should not write anywhere inside its bundle. This
behavior is explicitly forbidden by Apple. This invalidates the entire bundle,
particularly its code identity. Debug builds will now long into the user data
directory.

BUG=688959
==========

to

==========
Log into the user-data-dir instead of Chrome's bundle.

Even for debug builds, Chrome should not write anywhere inside its bundle. This
behavior is explicitly forbidden by Apple. This invalidates the entire bundle,
particularly its code identity. Debug builds will now long into the user data
directory.

BUG=688959

Review-Url: https://codereview.chromium.org/2679133004
Cr-Commit-Position: refs/heads/master@{#451799}
Committed:
https://chromium.googlesource.com/chromium/src/+/344ea468c3a47b782e5cd0a6d7f8...
==========

[commit-bot: I haz the power, 2017-02-21 18:20:06]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/344ea468c3a47b782e5cd0a6d7f8...