Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1169)

Issue 2679133002: Merge "[NTP::SectionOrder] Track category index after it has been ..." (Closed)

Created:
3 years, 10 months ago by vitaliii
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Merge "[NTP::SectionOrder] Track category index after it has been ..." This is a merge of https://codereview.chromium.org/2668063004 into M57 (branch 2987). There were no conflicts, it has been tested on a device + unittests. Original description: Add a new metric to track category index after it has been moved up due to a click. This is done in order to check how stable to order is and whether it is becoming more stable. BUG=687505 Review-Url: https://codereview.chromium.org/2668063004 Cr-Commit-Position: refs/heads/master@{#447968} (cherry picked from commit 7496904fab33e2c38f8c6ec6cfad27ebd158c1f4) Review-Url: https://codereview.chromium.org/2679133002 . Cr-Commit-Position: refs/branch-heads/2987@{#360} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/59022d2e77967435d18cbe426f18793151d1eb9d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -8 lines) Patch
M components/ntp_snippets/category_rankers/click_based_category_ranker.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M components/ntp_snippets/category_rankers/click_based_category_ranker_unittest.cc View 7 chunks +105 lines, -8 lines 0 comments Download
M components/ntp_snippets/content_suggestions_metrics.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/ntp_snippets/content_suggestions_metrics.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
vitaliii
3 years, 10 months ago (2017-02-07 14:06:41 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
59022d2e77967435d18cbe426f18793151d1eb9d.

Powered by Google App Engine
This is Rietveld 408576698