Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 2679103005: Remove markDead() and isDead() (Closed)

Created:
3 years, 10 months ago by haraken
Modified:
3 years, 10 months ago
Reviewers:
sof
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), haraken, blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove markDead() and isDead() After the per-thread heap was shipped, markDead() is no longer reachable. This CL removes code that uses the dead bit. BUG=671856 Review-Url: https://codereview.chromium.org/2679103005 Cr-Commit-Position: refs/heads/master@{#448956} Committed: https://chromium.googlesource.com/chromium/src/+/4b9ec9d0dd42483207e9fab00d11f3df253d18e4

Patch Set 1 #

Total comments: 2

Patch Set 2 : temp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -85 lines) Patch
M third_party/WebKit/Source/platform/heap/HeapPage.h View 1 6 chunks +2 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.cpp View 7 chunks +6 lines, -60 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
haraken
PTAL https://codereview.chromium.org/2679103005/diff/1/third_party/WebKit/Source/platform/heap/HeapPage.h File third_party/WebKit/Source/platform/heap/HeapPage.h (right): https://codereview.chromium.org/2679103005/diff/1/third_party/WebKit/Source/platform/heap/HeapPage.h#newcode161 third_party/WebKit/Source/platform/heap/HeapPage.h:161: // a promptly freed header. I'll look into ...
3 years, 10 months ago (2017-02-08 09:18:07 UTC) #2
sof
lgtm https://codereview.chromium.org/2679103005/diff/1/third_party/WebKit/Source/platform/heap/HeapPage.h File third_party/WebKit/Source/platform/heap/HeapPage.h (right): https://codereview.chromium.org/2679103005/diff/1/third_party/WebKit/Source/platform/heap/HeapPage.h#newcode161 third_party/WebKit/Source/platform/heap/HeapPage.h:161: // a promptly freed header. On 2017/02/08 09:18:06, ...
3 years, 10 months ago (2017-02-08 09:24:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2679103005/20001
3 years, 10 months ago (2017-02-08 09:33:10 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 11:14:22 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4b9ec9d0dd42483207e9fab00d11...

Powered by Google App Engine
This is Rietveld 408576698