Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects at most 10 tests.

BUG=639732
Review-Url: https://codereview.chromium.org/2679083003
Cr-Commit-Position: refs/heads/master@{#451310}
Committed: https://chromium.googlesource.com/chromium/src/+/1d0e24ae0f6c6b5e8c37dc705ac8896073c106b8

[zakerinasab, 2017-02-07 19:11:23]

Description was changed from

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects at most 10 tests.

BUG=639732
==========

to

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects at most 10 tests.

BUG=639732
==========

[zakerinasab, 2017-02-07 19:11:23]

zakerinasab@chromium.org changed reviewers:
+ junov@chromium.org

[Justin Novosad, 2017-02-16 15:34:30]

https://codereview.chromium.org/2679083003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-invalid-fillstyle.html
(right):

https://codereview.chromium.org/2679083003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-invalid-fillstyle.html:16: },
'Series of tests to ensure correct behaviour on an invalid fillStyle()');
This is not really a series

https://codereview.chromium.org/2679083003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-invalid-strokestyle.html
(right):

https://codereview.chromium.org/2679083003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-invalid-strokestyle.html:19:
}, 'Series of tests to ensure correct behaviour on an invalid strokeStyle()');
Not a series

https://codereview.chromium.org/2679083003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-invalid-values.html
(right):

https://codereview.chromium.org/2679083003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-invalid-values.html:39:
generate_tests(
Why generate_tests inside a test?

[zakerinasab, 2017-02-16 17:48:12]

Comments addressed.

https://codereview.chromium.org/2679083003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-invalid-fillstyle.html
(right):

https://codereview.chromium.org/2679083003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-invalid-fillstyle.html:16: },
'Series of tests to ensure correct behaviour on an invalid fillStyle()');
On 2017/02/16 15:34:29, Justin Novosad wrote:
> This is not really a series

Acknowledged.

https://codereview.chromium.org/2679083003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-invalid-strokestyle.html
(right):

https://codereview.chromium.org/2679083003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-invalid-strokestyle.html:19:
}, 'Series of tests to ensure correct behaviour on an invalid strokeStyle()');
On 2017/02/16 15:34:30, Justin Novosad wrote:
> Not a series

Acknowledged.

https://codereview.chromium.org/2679083003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-invalid-values.html
(right):

https://codereview.chromium.org/2679083003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-invalid-values.html:39:
generate_tests(
On 2017/02/16 15:34:30, Justin Novosad wrote:
> Why generate_tests inside a test?

Huh. Strange mistake. Corrected.

[Justin Novosad, 2017-02-16 17:57:42]

lgtm

[zakerinasab, 2017-02-16 17:58:43]

The CQ bit was checked by zakerinasab@chromium.org

[commit-bot: I haz the power, 2017-02-16 17:59:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 19:11:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 19:11:02]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[zakerinasab, 2017-02-16 20:16:48]

On 2017/02/16 19:11:02, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

Some of the test cases in canvas-imageSmoothingQuality.html are failing on gpu:

https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/virtual/g...

Should I remove these test cases?

[Justin Novosad, 2017-02-16 20:48:21]

Mark the gpu variant as failing in TestExpectations

[Justin Novosad, 2017-02-16 20:48:54]

On 2017/02/16 20:48:21, Justin Novosad wrote:
> Mark the gpu variant as failing in TestExpectations

And of course, file corresponding bug if there isn't one already.

[zakerinasab, 2017-02-17 14:46:24]

On 2017/02/16 20:48:54, Justin Novosad wrote:
> On 2017/02/16 20:48:21, Justin Novosad wrote:
> > Mark the gpu variant as failing in TestExpectations
> 
> And of course, file corresponding bug if there isn't one already.

Done. crbug.com/693568.

[zakerinasab, 2017-02-17 14:46:33]

The CQ bit was checked by zakerinasab@chromium.org

[zakerinasab, 2017-02-17 14:46:34]

The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org
Link to the patchset: https://codereview.chromium.org/2679083003/#ps60001
(title: "Adding virtual/gpu/fast/canvas/canvas-imageSmoothingQuality.html to
TestExpectations")

[commit-bot: I haz the power, 2017-02-17 14:46:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 15:50:37]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487342793709120,
"parent_rev": "b38b621d8f15c6f424160df8a5be8d3398ebd4ad", "commit_rev":
"1d0e24ae0f6c6b5e8c37dc705ac8896073c106b8"}

[commit-bot: I haz the power, 2017-02-17 15:51:11]

Description was changed from

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects at most 10 tests.

BUG=639732
==========

to

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects at most 10 tests.

BUG=639732

Review-Url: https://codereview.chromium.org/2679083003
Cr-Commit-Position: refs/heads/master@{#451310}
Committed:
https://chromium.googlesource.com/chromium/src/+/1d0e24ae0f6c6b5e8c37dc705ac8...
==========

[commit-bot: I haz the power, 2017-02-17 15:51:12]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/1d0e24ae0f6c6b5e8c37dc705ac8...