Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 2679073004: Physical Web: Remove extraneous file (Closed)

Created:
3 years, 10 months ago by Peter Wen
Modified:
3 years, 10 months ago
Reviewers:
nyquist, cco3
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Physical Web: Remove extraneous file PhysicalWebOptInActivity.java is not referenced in any gn files and is blocking our generate_gradle.py script from using the full directory. BUG=620034 Review-Url: https://codereview.chromium.org/2679073004 Cr-Commit-Position: refs/heads/master@{#448980} Committed: https://chromium.googlesource.com/chromium/src/+/81022874e21cac29a6d57ac820ef26f479700fc6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -86 lines) Patch
D chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebOptInActivity.java View 1 chunk +0 lines, -86 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Peter Wen
PTAL
3 years, 10 months ago (2017-02-07 18:16:31 UTC) #2
cco3
Thank you! I missed this in my change.
3 years, 10 months ago (2017-02-07 19:40:40 UTC) #4
cco3
Hi nyquist@, this is a small followup on one of my cleanup changes.
3 years, 10 months ago (2017-02-07 19:41:04 UTC) #5
nyquist
lgtm
3 years, 10 months ago (2017-02-07 23:37:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2679073004/1
3 years, 10 months ago (2017-02-08 13:41:25 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 13:46:19 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/81022874e21cac29a6d57ac820ef...

Powered by Google App Engine
This is Rietveld 408576698