Issue 267903003: [New Multicolumn] Remove RenderRegionSet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 267903003: [New Multicolumn] Remove RenderRegionSet. (Closed)

Created:
6 years, 7 months ago by mstensho (USE GERRIT)

Modified:
6 years, 7 months ago

Reviewers:
ojan, esprehn, rune, Julien - ping for review

CC:
blink-reviews, mstensho+blink_opera.com, blink-reviews-rendering, chromiumbugtracker_adobe.com, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

[New Multicolumn] Remove RenderRegionSet. It only did one thing, and that one thing can be done directly by RenderMultiColumnSet instead. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173411

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -131 lines)			Patch
M	Source/core/core.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/rendering/RenderFlowThread.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderFlowThread.cpp	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/core/rendering/RenderMultiColumnFlowThread.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/rendering/RenderMultiColumnFlowThread.cpp	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	Source/core/rendering/RenderMultiColumnSet.h	View	3 chunks	+6 lines, -2 lines	0 comments	Download
M	Source/core/rendering/RenderMultiColumnSet.cpp	View	2 chunks	+18 lines, -1 line	0 comments	Download
M	Source/core/rendering/RenderRegion.h	View	2 chunks	+3 lines, -5 lines	0 comments	Download
D	Source/core/rendering/RenderRegionSet.h	View	1 chunk	+0 lines, -60 lines	0 comments	Download
D	Source/core/rendering/RenderRegionSet.cpp	View	1 chunk	+0 lines, -57 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/267903003/1

6 years, 7 months ago (2014-05-06 17:07:25 UTC) #5

Message was sent while issue was closed.

Change committed as 173411

Expand Messages | Collapse Messages