Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Issue 267903003: [New Multicolumn] Remove RenderRegionSet. (Closed)

Created:
6 years, 7 months ago by mstensho (USE GERRIT)
Modified:
6 years, 7 months ago
CC:
blink-reviews, mstensho+blink_opera.com, blink-reviews-rendering, chromiumbugtracker_adobe.com, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[New Multicolumn] Remove RenderRegionSet. It only did one thing, and that one thing can be done directly by RenderMultiColumnSet instead. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173411

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -131 lines) Patch
M Source/core/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderFlowThread.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderFlowThread.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderMultiColumnFlowThread.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderMultiColumnFlowThread.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderMultiColumnSet.h View 3 chunks +6 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderMultiColumnSet.cpp View 2 chunks +18 lines, -1 line 0 comments Download
M Source/core/rendering/RenderRegion.h View 2 chunks +3 lines, -5 lines 0 comments Download
D Source/core/rendering/RenderRegionSet.h View 1 chunk +0 lines, -60 lines 0 comments Download
D Source/core/rendering/RenderRegionSet.cpp View 1 chunk +0 lines, -57 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mstensho (USE GERRIT)
6 years, 7 months ago (2014-05-05 14:50:08 UTC) #1
mstensho (USE GERRIT)
6 years, 7 months ago (2014-05-06 07:48:22 UTC) #2
rune
non-owner lgtm
6 years, 7 months ago (2014-05-06 08:26:01 UTC) #3
Julien - ping for review
lgtm
6 years, 7 months ago (2014-05-06 17:07:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/267903003/1
6 years, 7 months ago (2014-05-06 17:07:25 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-06 18:13:19 UTC) #6
Message was sent while issue was closed.
Change committed as 173411

Powered by Google App Engine
This is Rietveld 408576698