Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2679013004:
[DevTools] Show an empty Manifest view if no manifest (Closed)
|
Created:
3 years, 10 months ago by eostroukhov Modified:
3 years, 10 months ago Reviewers:
pfeldman CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[DevTools] Show an empty Manifest view if no manifest
BUG=689252
Review-Url: https://codereview.chromium.org/2679013004
Cr-Commit-Position: refs/heads/master@{#448857}
Committed: https://chromium.googlesource.com/chromium/src/+/dc9da748141ad5f270ad75435a7ae63ac9227e64
Patch Set 1 #Patch Set 2 : [DevTools] Disable "Manifest" if the site has none. #
Total comments: 8
Patch Set 3 : [DevTools] Disable "Manifest" if the site has none. #
Total comments: 4
Patch Set 4 : Redid and introduced an empty view #
Total comments: 2
Patch Set 5 : [DevTools] Show an empty pane for no manifest #Messages
Total messages: 34 (23 generated)
The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run
eostroukhov@chromium.org changed reviewers: + pfeldman@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
A fair bit of complexity is added + the flickering part concerns me a lot. https://codereview.chromium.org/2679013004/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js (right): https://codereview.chromium.org/2679013004/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js:48: setTimeout(() => this._reportView.setURL(Components.Linkifier.linkifyURL(url))); That's a bad assumption to make. https://codereview.chromium.org/2679013004/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js (right): https://codereview.chromium.org/2679013004/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:163: this._manifestTreeElement._startTracking(target); We only show manifest for the main target, see below. https://codereview.chromium.org/2679013004/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:1493: resourceTreeModel.addEventListener(SDK.ResourceTreeModel.Events.MainFrameNavigated, this._updateManifest, this); You should instead set this listener on the targetManager. https://codereview.chromium.org/2679013004/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:1535: this._storagePanel.closeVisibleView(); You might end up resetting the view upon navigation through redirect, etc.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run
Please take another look. https://codereview.chromium.org/2679013004/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js (right): https://codereview.chromium.org/2679013004/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js:48: setTimeout(() => this._reportView.setURL(Components.Linkifier.linkifyURL(url))); On 2017/02/07 00:25:35, pfeldman wrote: > That's a bad assumption to make. I do not see a cleaner option atm. Note - this is not a regression, the issue had been here for awhile. https://codereview.chromium.org/2679013004/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js (right): https://codereview.chromium.org/2679013004/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:163: this._manifestTreeElement._startTracking(target); On 2017/02/07 00:25:35, pfeldman wrote: > We only show manifest for the main target, see below. Acknowledged. https://codereview.chromium.org/2679013004/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:1493: resourceTreeModel.addEventListener(SDK.ResourceTreeModel.Events.MainFrameNavigated, this._updateManifest, this); On 2017/02/07 00:25:35, pfeldman wrote: > You should instead set this listener on the targetManager. Done. Thanks for reminding me! https://codereview.chromium.org/2679013004/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:1535: this._storagePanel.closeVisibleView(); On 2017/02/07 00:25:35, pfeldman wrote: > You might end up resetting the view upon navigation through redirect, etc. I think it is ok to let the user see "broken" panel in some rare cases. I changed the code.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2679013004/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js (right): https://codereview.chromium.org/2679013004/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:119: event => this._manifestTreeElement.loadManifest(event.data.target())); You only want to load manifest if the view is visible. https://codereview.chromium.org/2679013004/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:121: var mainTarget = SDK.targetManager.mainTarget(); ditto
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [DevTools] Disable "Manifest" if the site has none. BUG=689252 ========== to ========== [DevTools] Show an empty Manifest view if no manifest BUG=689252 ==========
Redid to show an empty view. Please take another look. https://codereview.chromium.org/2679013004/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js (right): https://codereview.chromium.org/2679013004/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:119: event => this._manifestTreeElement.loadManifest(event.data.target())); On 2017/02/07 02:11:44, pfeldman wrote: > You only want to load manifest if the view is visible. Done. https://codereview.chromium.org/2679013004/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:121: var mainTarget = SDK.targetManager.mainTarget(); On 2017/02/07 02:11:44, pfeldman wrote: > ditto Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2679013004/diff/60001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js (right): https://codereview.chromium.org/2679013004/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js:98: setTimeout(() => this._reportView.setURL(Components.Linkifier.linkifyURL(url))); Drop the setTimeout and this is fine to land.
The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run
The CQ bit was unchecked by eostroukhov@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Thanks for the review. Submitting. https://codereview.chromium.org/2679013004/diff/60001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js (right): https://codereview.chromium.org/2679013004/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js:98: setTimeout(() => this._reportView.setURL(Components.Linkifier.linkifyURL(url))); On 2017/02/07 23:04:38, pfeldman wrote: > Drop the setTimeout and this is fine to land. Done :(
The CQ bit was checked by eostroukhov@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from pfeldman@chromium.org Link to the patchset: https://codereview.chromium.org/2679013004/#ps80001 (title: "[DevTools] Show an empty pane for no manifest")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by eostroukhov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1486516759904970,
"parent_rev": "c62b316ce3138b7db046f25cf0d7cd7f5901dcf5", "commit_rev":
"dc9da748141ad5f270ad75435a7ae63ac9227e64"}
Message was sent while issue was closed.
Description was changed from ========== [DevTools] Show an empty Manifest view if no manifest BUG=689252 ========== to ========== [DevTools] Show an empty Manifest view if no manifest BUG=689252 Review-Url: https://codereview.chromium.org/2679013004 Cr-Commit-Position: refs/heads/master@{#448857} Committed: https://chromium.googlesource.com/chromium/src/+/dc9da748141ad5f270ad75435a7a... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/dc9da748141ad5f270ad75435a7a... |
