cc: Clean up naming of paint-related identifiers

cc: Clean up naming of paint-related identifiers

Also fix a few things that should stay SkPicture and not PaintRecord.

This is a followup to https://codereview.chromium.org/2640983002 that
only changed types.

BUG=671433
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2678903003
Cr-Commit-Position: refs/heads/master@{#448668}
Committed: https://chromium.googlesource.com/chromium/src/+/bb7c4bcf9afabcbcb4ae2eef8b878466355cb62a

[enne (OOO), 2017-02-07 02:17:13]

Description was changed from

==========
cc: Clean up naming of paint-related identifiers

Also fix a few things that should stay SkPicture and not PaintRecord.

This is a followup to https://codereview.chromium.org/2640983002 that
only changed types.

BUG=671433
==========

to

==========
cc: Clean up naming of paint-related identifiers

Also fix a few things that should stay SkPicture and not PaintRecord.

This is a followup to https://codereview.chromium.org/2640983002 that
only changed types.

BUG=671433
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[enne (OOO), 2017-02-07 02:20:04]

enne@chromium.org changed reviewers:
+ danakj@chromium.org

[enne (OOO), 2017-02-07 02:20:05]

I have a patch that converts all the identifiers everywhere, but am just going
to land in pieces for simplicity.

https://codereview.chromium.org/2678903003/diff/1/cc/layers/layer.h
File cc/layers/layer.h (right):

https://codereview.chromium.org/2678903003/diff/1/cc/layers/layer.h#newcode331
cc/layers/layer.h:331: virtual sk_sp<SkPicture> GetPicture() const;
This appears to only be used by tests that want bitmaps.  There's a gpu
benchmarking extension and paint artifact compositor test.  So, I think this can
just stay as a flattened picture for now.

[enne (OOO), 2017-02-07 02:24:45]

The CQ bit was checked by enne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 02:25:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 04:01:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 04:01:30]

Dry run: This issue passed the CQ dry run.

[danakj, 2017-02-07 16:02:35]

LGTM

[enne (OOO), 2017-02-07 17:55:00]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2017-02-07 17:55:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 17:59:54]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486490100657690, "parent_rev":
"b4e709ac6f105542e169b4a9541546e3477e3ba7", "commit_rev":
"bb7c4bcf9afabcbcb4ae2eef8b878466355cb62a"}

[commit-bot: I haz the power, 2017-02-07 18:00:27]

Description was changed from

==========
cc: Clean up naming of paint-related identifiers

Also fix a few things that should stay SkPicture and not PaintRecord.

This is a followup to https://codereview.chromium.org/2640983002 that
only changed types.

BUG=671433
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Clean up naming of paint-related identifiers

Also fix a few things that should stay SkPicture and not PaintRecord.

This is a followup to https://codereview.chromium.org/2640983002 that
only changed types.

BUG=671433
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2678903003
Cr-Commit-Position: refs/heads/master@{#448668}
Committed:
https://chromium.googlesource.com/chromium/src/+/bb7c4bcf9afabcbcb4ae2eef8b87...
==========

[commit-bot: I haz the power, 2017-02-07 18:00:28]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bb7c4bcf9afabcbcb4ae2eef8b87...