Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 2678863004: DevTools: eliminate UI.Icon transforms (Closed)

Created:
3 years, 10 months ago by lushnikov
Modified:
3 years, 10 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: eliminate UI.Icon transforms Today, a few icons are using transforms in their descriptors. This saves some space in the spritesheet, but this is a hackish solution which makes dealing with icons harder. This patch explicitly defines these icons in spritesheets. This is a prerequisite for the spritesheet assembler introduction. As a drive-by and as a preporation for icon migration, this patch cleans up spritesheets: - groups all icons in smallIcons.svg, toolbarButtonGlyphs.svg and resourceGlyphs.svg - kills hidden SVG layer which was not actually used in smallIcons.svg R=dgozman@chromium.org, pfeldman BUG=689188 R=dgozman@chromium.org, pfeldman@chromium.org Review-Url: https://codereview.chromium.org/2678863004 Cr-Commit-Position: refs/heads/master@{#448461} Committed: https://chromium.googlesource.com/chromium/src/+/b4eda7f379a496b5167b6905cadea3b38be6bdf8

Patch Set 1 #

Patch Set 2 : revert convert_svg_images_to_png changes #

Patch Set 3 : recompile png's with inkscape v0.48 #

Messages

Total messages: 9 (5 generated)
lushnikov
please, take a look
3 years, 10 months ago (2017-02-06 21:49:07 UTC) #2
pfeldman
lgtm
3 years, 10 months ago (2017-02-06 21:52:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2678863004/40001
3 years, 10 months ago (2017-02-06 22:56:04 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 00:24:00 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b4eda7f379a496b5167b6905cade...

Powered by Google App Engine
This is Rietveld 408576698