Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2678863003: Re-enable a browser test on Windows (Closed)

Created:
3 years, 10 months ago by EhsanK
Modified:
3 years, 10 months ago
Reviewers:
alexmos
CC:
chromium-reviews, site_isolation_reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable a browser test on Windows The test was disabled due to being flakey. It seems like a recent CL has fixed the issue (https://codereview.chromium.org/2544223002/). BUG=666379 Review-Url: https://codereview.chromium.org/2678863003 Cr-Commit-Position: refs/heads/master@{#448562} Committed: https://chromium.googlesource.com/chromium/src/+/bdd4517373c99f0af9c16b9f550193cb89735d66

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M chrome/browser/chrome_site_per_process_browsertest.cc View 1 chunk +1 line, -10 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
EhsanK
Hello Alex, PTAL.
3 years, 10 months ago (2017-02-06 17:47:34 UTC) #4
alexmos
LGTM
3 years, 10 months ago (2017-02-06 22:35:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2678863003/1
3 years, 10 months ago (2017-02-07 06:30:59 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 06:46:44 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bdd4517373c99f0af9c16b9f5501...

Powered by Google App Engine
This is Rietveld 408576698