Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Issue 2678843003: Convert WebstoreInlineInstaller to use the new navigation callbacks. (Closed)

Created:
3 years, 10 months ago by jam
Modified:
3 years, 10 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert WebstoreInlineInstaller to use the new navigation callbacks. BUG=682002 Review-Url: https://codereview.chromium.org/2678843003 Cr-Commit-Position: refs/heads/master@{#448295} Committed: https://chromium.googlesource.com/chromium/src/+/411be4c02c6f76c81fa2f8891163848660349e43

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M chrome/browser/extensions/webstore_inline_installer.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/webstore_inline_installer.cc View 2 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
jam
the last one in extensions :)
3 years, 10 months ago (2017-02-06 17:01:40 UTC) #7
Devlin
On 2017/02/06 17:01:40, jam wrote: > the last one in extensions :) Woo! lgtm. Thanks ...
3 years, 10 months ago (2017-02-06 17:17:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2678843003/1
3 years, 10 months ago (2017-02-06 17:27:03 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 17:49:46 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/411be4c02c6f76c81fa2f8891163...

Powered by Google App Engine
This is Rietveld 408576698