Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 2678823002: Invokes TabParentingGlobalObserver for every Tab parented. (Closed)

Created:
3 years, 10 months ago by sdefresne
Modified:
3 years, 10 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Invokes TabParentingGlobalObserver for every Tab parented. TabParentingGlobalObserver documentation states that it "[a]llows clients to observe every tab (i.e., WebState) that is parented" so fix TabModel to invokes it for every tab that is parented not just the ones that are restored from a session. BUG=687207 Review-Url: https://codereview.chromium.org/2678823002 Cr-Commit-Position: refs/heads/master@{#448250} Committed: https://chromium.googlesource.com/chromium/src/+/62487280fe60b83fd4e66730c1e0478c55528faf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ios/chrome/browser/tabs/tab_model.mm View 2 chunks +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
sdefresne
Please take a look.
3 years, 10 months ago (2017-02-06 14:33:25 UTC) #4
rohitrao (ping after 24h)
lgtm
3 years, 10 months ago (2017-02-06 14:35:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2678823002/1
3 years, 10 months ago (2017-02-06 14:57:29 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 15:03:33 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/62487280fe60b83fd4e66730c1e0...

Powered by Google App Engine
This is Rietveld 408576698