Pass notification deadline timestamp as a jlong

Pass notification deadline timestamp as a jlong

Java timestamps are jlongs (int64_t) and passing a jint (int32_t)
truncates them to late January, 1970 at the latest. In particular, use
jlong's max value to indicate "no deadline".

BUG=689022
Review-Url: https://codereview.chromium.org/2678813002
Cr-Commit-Position: refs/heads/master@{#448285}
Committed: https://chromium.googlesource.com/chromium/src/+/68c2b21598d1ffb959056909f6b4fa8bf7a17155

[sfiera, 2017-02-06 13:06:02]

The CQ bit was checked by sfiera@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 13:06:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sfiera, 2017-02-06 13:06:20]

sfiera@chromium.org changed reviewers:
+ bauerb@chromium.org

[sfiera, 2017-02-06 13:06:21]

Oops. This is going to need a merge.

[commit-bot: I haz the power, 2017-02-06 13:37:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 13:37:44]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2017-02-06 17:11:14]

LGTM

Oops… :)

I guess compilers don't warn about this? :(

[sfiera, 2017-02-06 17:28:23]

On 2017/02/06 17:11:14, Bernhard Bauer wrote:
> LGTM
> 
> Oops… :)
> 
> I guess compilers don't warn about this? :(

There's -Wconversion, but it's not included in -Wall, probably because it's too
noisy for most C++ code. For instance, "char b = 'A' + 1" is a narrowing
conversion, because addition promotes to char to int, and then you're narrowing
back to char.

[sfiera, 2017-02-06 17:28:31]

The CQ bit was checked by sfiera@chromium.org

[commit-bot: I haz the power, 2017-02-06 17:29:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 17:35:57]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486402111518000, "parent_rev":
"4c247781839fa869394c70ab84fa4ba77d7e07ab", "commit_rev":
"68c2b21598d1ffb959056909f6b4fa8bf7a17155"}

[commit-bot: I haz the power, 2017-02-06 17:36:37]

Description was changed from

==========
Pass notification deadline timestamp as a jlong

Java timestamps are jlongs (int64_t) and passing a jint (int32_t)
truncates them to late January, 1970 at the latest. In particular, use
jlong's max value to indicate "no deadline".

BUG=689022
==========

to

==========
Pass notification deadline timestamp as a jlong

Java timestamps are jlongs (int64_t) and passing a jint (int32_t)
truncates them to late January, 1970 at the latest. In particular, use
jlong's max value to indicate "no deadline".

BUG=689022

Review-Url: https://codereview.chromium.org/2678813002
Cr-Commit-Position: refs/heads/master@{#448285}
Committed:
https://chromium.googlesource.com/chromium/src/+/68c2b21598d1ffb959056909f6b4...
==========

[commit-bot: I haz the power, 2017-02-06 17:36:38]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/68c2b21598d1ffb959056909f6b4...