Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2678803002: [Media>UI] Reset media metadata when navigating away (Closed)

Created:
3 years, 10 months ago by Zhiqiang Zhang (Slow)
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Media>UI] Reset media metadata when navigating away There is a bug caused by media metadata being not properly reset when navigating away, so that the notification title and artist stays the same when the new page starts to play media. This CL fixes the issue. BUG=687973 Review-Url: https://codereview.chromium.org/2675693004 Cr-Commit-Position: refs/heads/master@{#448231} (cherry picked from commit b0a34cb69bdca47cfe3dd3d1cead96446391dcbf) Review-Url: https://codereview.chromium.org/2678803002 . Cr-Commit-Position: refs/branch-heads/2987@{#321} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/b28681089588dd01dde75af82f849a80febebea0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -32 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java View 2 chunks +12 lines, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java View 7 chunks +48 lines, -31 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Zhiqiang Zhang (Slow)
3 years, 10 months ago (2017-02-06 12:47:32 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b28681089588dd01dde75af82f849a80febebea0.

Powered by Google App Engine
This is Rietveld 408576698