Fix variations service DCHECK and add LOAD_DO_NOT_SEND_AUTH_DATA.

Fix variations service DCHECK and add LOAD_DO_NOT_SEND_AUTH_DATA.

The DCHECK could fire if the fetch timer fires before the previous
request finished. This normally shouldn't happen - but could if
Chrome was paused (via debugger or machine suspend).

Also while changing this code, adds the LOAD_DO_NOT_SEND_AUTH_DATA
flag when making the request, which was suggested for UMA and UKM
fetches and makes sense here too - since variations server doesn't
need that info at all.

BUG=669542
Review-Url: https://codereview.chromium.org/2678783003
Cr-Commit-Position: refs/heads/master@{#448275}
Committed: https://chromium.googlesource.com/chromium/src/+/2f480d6a78ddefc9339fb90f3318a1c1b583a77c

[Alexei Svitkine (slow), 2017-02-06 15:33:06]

asvitkine@chromium.org changed reviewers:
+ rkaplow@chromium.org

[rkaplow, 2017-02-06 16:18:01]

lgtm

[Alexei Svitkine (slow), 2017-02-06 16:19:01]

The CQ bit was checked by asvitkine@chromium.org

[commit-bot: I haz the power, 2017-02-06 16:19:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 17:00:23]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486397941519340, "parent_rev":
"d5d8edbef8317dfc1e78469403e22fe6e38d12c4", "commit_rev":
"2f480d6a78ddefc9339fb90f3318a1c1b583a77c"}

[commit-bot: I haz the power, 2017-02-06 17:04:32]

Description was changed from

==========
Fix variations service DCHECK and add LOAD_DO_NOT_SEND_AUTH_DATA.

The DCHECK could fire if the fetch timer fires before the previous
request finished. This normally shouldn't happen - but could if
Chrome was paused (via debugger or machine suspend).

Also while changing this code, adds the LOAD_DO_NOT_SEND_AUTH_DATA
flag when making the request, which was suggested for UMA and UKM
fetches and makes sense here too - since variations server doesn't
need that info at all.

BUG=669542
==========

to

==========
Fix variations service DCHECK and add LOAD_DO_NOT_SEND_AUTH_DATA.

The DCHECK could fire if the fetch timer fires before the previous
request finished. This normally shouldn't happen - but could if
Chrome was paused (via debugger or machine suspend).

Also while changing this code, adds the LOAD_DO_NOT_SEND_AUTH_DATA
flag when making the request, which was suggested for UMA and UKM
fetches and makes sense here too - since variations server doesn't
need that info at all.

BUG=669542

Review-Url: https://codereview.chromium.org/2678783003
Cr-Commit-Position: refs/heads/master@{#448275}
Committed:
https://chromium.googlesource.com/chromium/src/+/2f480d6a78ddefc9339fb90f3318...
==========

[commit-bot: I haz the power, 2017-02-06 17:04:33]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2f480d6a78ddefc9339fb90f3318...