Make wpt-import --auto-update pass if the issue is closed after CQ.

Make wpt-import --auto-update pass if the issue is closed after CQ.

BUG=682092
Review-Url: https://codereview.chromium.org/2678773003
Cr-Commit-Position: refs/heads/master@{#448442}
Committed: https://chromium.googlesource.com/chromium/src/+/9d2045cf28b9e8f5ab2c50df3733818682a62373

[qyearsley, 2017-02-06 19:49:30]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 19:50:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[qyearsley, 2017-02-06 19:52:35]

qyearsley@chromium.org changed reviewers:
+ jeffcarp@chromium.org

[qyearsley, 2017-02-06 19:52:36]

This is meant to be a fix for the issue that jobs listed at
https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller
are still red even if an import was successfully completed.

This change makes it so that the is considered to be "successful" if the issue
is closed after the CQ run, which indicates that the CQ appears to have been
successful. The reasoning for this change is that I believe it's possible for CQ
to have non-required (FYI) jobs which fail and the CQ still passes, in which
case the job should be considered successful.

There may be some cases where someone (e.g. me) closes the issue manually even
though it failed, before the script is finished waiting for the try jobs... but
I think that this may be OK because the importer at least won't keep failing
without someone knowing about it.

[commit-bot: I haz the power, 2017-02-06 20:57:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 20:57:08]

Dry run: This issue passed the CQ dry run.

[jeffcarp, 2017-02-06 22:58:45]

看起来对我好

(this is what Google translate outputs for lgtm ^_^)

https://codereview.chromium.org/2678773003/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py
(right):

https://codereview.chromium.org/2678773003/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py:52:
host.executive = MockExecutive(output='closed ')
Should there be a space at the end of closed?

[qyearsley, 2017-02-06 23:15:39]

https://codereview.chromium.org/2678773003/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py
(right):

https://codereview.chromium.org/2678773003/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py:52:
host.executive = MockExecutive(output='closed ')
On 2017/02/06 at 22:58:45, jeffcarp wrote:
> Should there be a space at the end of closed?

I put that there to test whether it's OK to have whitespace in the output of
`git cl status --field=status`. Not really necessary, and it's not the main
point of the test, but it's also harmless and demonstrates that whitespace
doesn't matter.

[qyearsley, 2017-02-06 23:21:07]

On 2017/02/06 at 22:58:45, jeffcarp wrote:
> 看起来对我好
> 
> (this is what Google translate outputs for lgtm ^_^)
> 

Hah - this demonstrates an interesting grammatical ambiguity here

看起来 is roughly the same as "it looks <adj>", and 对我好 is literally to-me-good,
meaning "good to me / good for me". So 看起来对我好 could also be "it looks likes it's
good for me"...

Maybe a more accurate (but longer) translation would be "我觉得看起来不错" ~= "I think
that it looks alright"

[qyearsley, 2017-02-06 23:21:52]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2017-02-06 23:23:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[qyearsley, 2017-02-06 23:24:05]

On 2017/02/06 at 23:21:07, qyearsley wrote:
> On 2017/02/06 at 22:58:45, jeffcarp wrote:
> > 看起来对我好
> > 
> > (this is what Google translate outputs for lgtm ^_^)
> > 
> 
> Hah - this demonstrates an interesting grammatical ambiguity here
> 
> 看起来 is roughly the same as "it looks <adj>", and 对我好 is literally to-me-good,
meaning "good to me / good for me". So 看起来对我好 could also be "it looks likes it's
good for me"...
> 
> Maybe a more accurate (but longer) translation would be "我觉得看起来不错" ~= "I think
that it looks alright"

Japanese translation 私によく見える ... which according to the translator, the order is
something like "To me, good, looks"?

[commit-bot: I haz the power, 2017-02-06 23:29:22]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486423312103630, "parent_rev":
"3285e7db243ef17a0fbbda5ec5661325401401ca", "commit_rev":
"9d2045cf28b9e8f5ab2c50df3733818682a62373"}

[commit-bot: I haz the power, 2017-02-06 23:31:02]

Description was changed from

==========
Make wpt-import --auto-update pass if the issue is closed after CQ.

BUG=682092
==========

to

==========
Make wpt-import --auto-update pass if the issue is closed after CQ.

BUG=682092

Review-Url: https://codereview.chromium.org/2678773003
Cr-Commit-Position: refs/heads/master@{#448442}
Committed:
https://chromium.googlesource.com/chromium/src/+/9d2045cf28b9e8f5ab2c50df3733...
==========

[commit-bot: I haz the power, 2017-02-06 23:31:03]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9d2045cf28b9e8f5ab2c50df3733...