third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js - Issue 2678623002: DevTools: pass title when creating settings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

Issue 2678623002: DevTools: pass title when creating settings (Closed)

Patch Set: a Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/main/module.json ('K') | « third_party/WebKit/Source/devtools/front_end/sdk/module.json ('k') | third_party/WebKit/Source/devtools/front_end/timeline/CountersGraph.js » ('j') | third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js b/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

index 3be12c069bb5b90938221dc5d991db779cf8b996..aa45a0da74472372bc66d9b7761a291eaeb8a7bc 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

@@ -692,9 +692,8 @@ Sources.SourcesPanel = class extends UI.Panel {

debugToolbar.appendToolbarItem(this._pauseOnExceptionButton);

debugToolbar.appendSeparator();

- debugToolbar.appendToolbarItem(new UI.ToolbarCheckbox(

- Common.UIString('Async'), Common.UIString('Capture async stack traces'),

- Common.moduleSetting('enableAsyncStackTraces')));

+ debugToolbar.appendToolbarItem(new UI.ToolbarSettingCheckbox(

+ Common.moduleSetting('enableAsyncStackTraces'), Common.UIString('Capture async stack traces')));

pfeldman 2017/02/07 20:10:28 For example, here you want a shortcut.

luoe 2017/02/13 06:27:20 Done.

return debugToolbar;

}