third_party/WebKit/Source/devtools/front_end/timeline/CountersGraph.js - Issue 2678623002: DevTools: pass title when creating settings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/CountersGraph.js

Issue 2678623002: DevTools: pass title when creating settings (Closed)

Patch Set: a Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js ('K') | « third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js » ('j') | third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/CountersGraph.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/CountersGraph.js b/third_party/WebKit/Source/devtools/front_end/timeline/CountersGraph.js

index c1bec7d4aeae7d216d8b0604e8055987897e3528..520ffda3cc80db06c13d5f00b8606b466d199046 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/CountersGraph.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/CountersGraph.js

@@ -397,8 +397,8 @@ Timeline.CountersGraph.CounterUI = class {

this._formatter = formatter || Number.withThousandsSeparator;

var container = countersPane._infoWidget.element.createChild('div', 'memory-counter-selector-info');

- this._setting = Common.settings.createSetting('timelineCountersGraph-' + title, true);

- this._filter = new UI.ToolbarCheckbox(title, title, this._setting);

+ this._setting = Common.settings.createSetting('timelineCountersGraph-' + title, true, false, title);

+ this._filter = new UI.ToolbarSettingCheckbox(this._setting, title);

this._filter.inputElement.classList.add('-theme-preserve');

var color = Common.Color.parse(graphColor).setAlpha(0.5).asString(Common.Color.Format.RGBA);

if (color) {