Make MutationObserver observe parameter optional as per spec

Make MutationObserver observe parameter optional as per spec.

The spec for MutationObserver:
https://dom.spec.whatwg.org/#interface-mutationobserver

According to the spec, the observe() method has an "options" dictionary
parameter, which should be optional. The IDL definition of observe()
was missing the optional modifier, making the parameter required.

This CL corrects the IDL so that it conforms exactly with the spec. As it
turns out, the options parameter is effectively required, as the spec
requires at least one of the values to be set. The result of this change
is only observable in different error messages (the type thrown is the
same).

BUG=673698
Review-Url: https://codereview.chromium.org/2678583002
Cr-Commit-Position: refs/heads/master@{#448769}
Committed: https://chromium.googlesource.com/chromium/src/+/48d992b90f2a9a95bb591cf2a5d48baea27567df

[chasej, 2017-02-04 00:30:17]

The CQ bit was checked by chasej@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-04 00:30:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chasej, 2017-02-04 00:46:51]

Description was changed from

==========
Make MutationObserver observe parameter optional as per spec

BUG=673698
==========

to

==========
Make MutationObserver observe parameter optional as per spec.

The spec for MutationObserver:
https://dom.spec.whatwg.org/#interface-mutationobserver

According to the spec, the observe() method has an "options" dictionary
parameter, which should be optional. The IDL definition of observe()
was missing the optional modifier, making the parameter required.

This CL corrects the IDL so that it conforms exactly with the spec. As it
turns out, the options parameter is effectively required, as the spec
requires at least one of the values to be set. The result of this change
is only observable in different error messages (the type thrown is the
same).

BUG=673698
==========

[commit-bot: I haz the power, 2017-02-04 02:32:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-04 02:32:08]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[chasej, 2017-02-06 22:11:09]

The CQ bit was checked by chasej@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 22:11:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 23:35:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 23:35:36]

Dry run: This issue passed the CQ dry run.

[chasej, 2017-02-07 04:11:32]

chasej@chromium.org changed reviewers:
+ foolip@chromium.org

[chasej, 2017-02-07 04:11:32]

foolip@, please take a look.

[foolip, 2017-02-07 15:49:35]

The CQ bit was checked by foolip@chromium.org

[foolip, 2017-02-07 15:49:36]

lgtm

https://codereview.chromium.org/2678583002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/external/wpt/dom/interfaces-expected.txt
(left):

https://codereview.chromium.org/2678583002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/external/wpt/dom/interfaces-expected.txt:148:
FAIL MutationObserver interface: operation observe(Node,MutationObserverInit)
assert_equals: property has wrong .length expected 1 but got 2
Ah, right, the change is also visible in the function's .length. Good!

[commit-bot: I haz the power, 2017-02-07 15:50:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 15:54:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 15:54:27]

Failed to apply patch for
third_party/WebKit/Source/core/dom/MutationObserver.idl:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/Source/core/dom/MutationObserver.idl:34
  error: third_party/WebKit/Source/core/dom/MutationObserver.idl: patch does not
apply

Patch:       third_party/WebKit/Source/core/dom/MutationObserver.idl
Index: third_party/WebKit/Source/core/dom/MutationObserver.idl
diff --git a/third_party/WebKit/Source/core/dom/MutationObserver.idl
b/third_party/WebKit/Source/core/dom/MutationObserver.idl
index
35f6382b5748f4f2699e1eff02b97086d3644ea0..1439abec0a6a5aff5a1e0db327fdaef12fb8040d
100644
--- a/third_party/WebKit/Source/core/dom/MutationObserver.idl
+++ b/third_party/WebKit/Source/core/dom/MutationObserver.idl
@@ -34,7 +34,7 @@
     CustomConstructor(MutationCallback callback),
     Custom=VisitDOMWrapper,
 ] interface MutationObserver {
-    [RaisesException] void observe(Node target, MutationObserverInit options);
+    [RaisesException] void observe(Node target, optional MutationObserverInit
options);
     void disconnect();
     sequence<MutationRecord> takeRecords();
 };

[chasej, 2017-02-07 21:03:17]

The CQ bit was checked by chasej@chromium.org

[chasej, 2017-02-07 21:03:17]

The patchset sent to the CQ was uploaded after l-g-t-m from foolip@chromium.org
Link to the patchset: https://codereview.chromium.org/2678583002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-02-07 21:03:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 23:06:18]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486501397103970,
"parent_rev": "54fba2185344bf2be51819c39a7ab6ef2524112a", "commit_rev":
"48d992b90f2a9a95bb591cf2a5d48baea27567df"}

[commit-bot: I haz the power, 2017-02-07 23:06:50]

Description was changed from

==========
Make MutationObserver observe parameter optional as per spec.

The spec for MutationObserver:
https://dom.spec.whatwg.org/#interface-mutationobserver

According to the spec, the observe() method has an "options" dictionary
parameter, which should be optional. The IDL definition of observe()
was missing the optional modifier, making the parameter required.

This CL corrects the IDL so that it conforms exactly with the spec. As it
turns out, the options parameter is effectively required, as the spec
requires at least one of the values to be set. The result of this change
is only observable in different error messages (the type thrown is the
same).

BUG=673698
==========

to

==========
Make MutationObserver observe parameter optional as per spec.

The spec for MutationObserver:
https://dom.spec.whatwg.org/#interface-mutationobserver

According to the spec, the observe() method has an "options" dictionary
parameter, which should be optional. The IDL definition of observe()
was missing the optional modifier, making the parameter required.

This CL corrects the IDL so that it conforms exactly with the spec. As it
turns out, the options parameter is effectively required, as the spec
requires at least one of the values to be set. The result of this change
is only observable in different error messages (the type thrown is the
same).

BUG=673698

Review-Url: https://codereview.chromium.org/2678583002
Cr-Commit-Position: refs/heads/master@{#448769}
Committed:
https://chromium.googlesource.com/chromium/src/+/48d992b90f2a9a95bb591cf2a5d4...
==========

[commit-bot: I haz the power, 2017-02-07 23:06:51]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/48d992b90f2a9a95bb591cf2a5d4...