Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2678563002: Properly set up TestRenderFrameHost in DeclarativeChromeContentRulesRegistryTest. (Closed)

Created:
3 years, 10 months ago by krasin1
Modified:
3 years, 10 months ago
Reviewers:
jam
CC:
chromium-reviews, jam, darin-cc_chromium.org, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Properly set up TestRenderFrameHost in DeclarativeChromeContentRulesRegistryTest. This fixes an invalid cast detected by Control Flow Integrity check. BUG=688518 Review-Url: https://codereview.chromium.org/2678563002 Cr-Commit-Position: refs/heads/master@{#448370} Committed: https://chromium.googlesource.com/chromium/src/+/17c45669733a9c6acc7f3a0d095a92f118eb0e2a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
krasin1
3 years, 10 months ago (2017-02-03 23:09:09 UTC) #2
jam
lgtm, thanks
3 years, 10 months ago (2017-02-06 18:49:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2678563002/1
3 years, 10 months ago (2017-02-06 19:48:19 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 20:20:02 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/17c45669733a9c6acc7f3a0d095a...

Powered by Google App Engine
This is Rietveld 408576698