Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2678523002: Update a few pointerevent test and the automations (Closed)

Created:
3 years, 10 months ago by Navid Zolghadr
Modified:
3 years, 10 months ago
Reviewers:
mustaq
CC:
chromium-reviews, blink-reviews, blink-reviews-w3ctests_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update a few pointerevent test and the automations Update a few pointerevent automation instructions to use the latest common synthetic pointer action functions. Also update the corresponding tests to support multiple pointer types. BUG=629722 Review-Url: https://codereview.chromium.org/2678523002 Cr-Commit-Position: refs/heads/master@{#448413} Committed: https://chromium.googlesource.com/chromium/src/+/ffc3d3143b1f1220beca3b0a942c8d871baa8aa0

Patch Set 1 #

Patch Set 2 : Add exception for Mac due to the lack of touch support #

Total comments: 2

Messages

Total messages: 18 (12 generated)
Navid Zolghadr
3 years, 10 months ago (2017-02-06 15:11:08 UTC) #10
mustaq
https://codereview.chromium.org/2678523002/diff/20001/third_party/WebKit/LayoutTests/TestExpectations File third_party/WebKit/LayoutTests/TestExpectations (left): https://codereview.chromium.org/2678523002/diff/20001/third_party/WebKit/LayoutTests/TestExpectations#oldcode1441 third_party/WebKit/LayoutTests/TestExpectations:1441: crbug.com/630671 external/wpt/pointerevents/pointerevent_capture_suppressing_mouse-manual.html [ Skip ] - Shouldn't these skips ...
3 years, 10 months ago (2017-02-06 19:17:29 UTC) #11
Navid Zolghadr
https://codereview.chromium.org/2678523002/diff/20001/third_party/WebKit/LayoutTests/TestExpectations File third_party/WebKit/LayoutTests/TestExpectations (left): https://codereview.chromium.org/2678523002/diff/20001/third_party/WebKit/LayoutTests/TestExpectations#oldcode1441 third_party/WebKit/LayoutTests/TestExpectations:1441: crbug.com/630671 external/wpt/pointerevents/pointerevent_capture_suppressing_mouse-manual.html [ Skip ] On 2017/02/06 19:17:29, mustaq ...
3 years, 10 months ago (2017-02-06 19:23:05 UTC) #12
mustaq
So we have more tests passing now, great! Missed it, sorry. Re skipping the Mac ...
3 years, 10 months ago (2017-02-06 19:37:22 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2678523002/20001
3 years, 10 months ago (2017-02-06 21:17:48 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 22:22:36 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ffc3d3143b1f1220beca3b0a942c...

Powered by Google App Engine
This is Rietveld 408576698