Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 26785002: IDL compiler: [GetterRaisesException], [RaisesException] for getter (Closed)

Created:
7 years, 2 months ago by Nils Barth (inactive)
Modified:
7 years, 2 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive, kouhei (in TOK)
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -7 lines) Patch
M Source/bindings/scripts/unstable/v8_attributes.py View 1 3 chunks +11 lines, -7 lines 0 comments Download
M Source/bindings/templates/attributes.cpp View 1 1 chunk +6 lines, -0 lines 0 comments Download
M Source/bindings/tests/idls/TestObjectPython.idl View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestObjectPython.cpp View 1 3 chunks +36 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nils Barth (inactive)
7 years, 2 months ago (2013-10-10 02:31:11 UTC) #1
haraken
LGTM
7 years, 2 months ago (2013-10-10 02:33:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/26785002/5001
7 years, 2 months ago (2013-10-15 08:39:24 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-10-15 08:39:39 UTC) #4
Message was sent while issue was closed.
Change committed as 159651

Powered by Google App Engine
This is Rietveld 408576698