Source/bindings/templates/attributes.cpp - Issue 26785002: IDL compiler: [GetterRaisesException], [RaisesException] for getter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/attributes.cpp

Issue 26785002: IDL compiler: [GetterRaisesException], [RaisesException] for getter (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebased Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/templates/attributes.cpp

diff --git a/Source/bindings/templates/attributes.cpp b/Source/bindings/templates/attributes.cpp

index c71948dc66f78e4ad3949945b156b9d0b6b15a60..7e5276deda9edea9cc296509572de7e6b3f73d5d 100644

--- a/Source/bindings/templates/attributes.cpp

+++ b/Source/bindings/templates/attributes.cpp

@@ -29,6 +29,12 @@ static void {{attribute.name}}AttributeGetter(v8::Local<v8::String> name, const

return;

}

{% endif %}

+ {% if attribute.is_getter_raises_exception %}

+ ExceptionState es(info.GetIsolate());

+ {{attribute.cpp_type}} {{attribute.cpp_value}} = {{attribute.cpp_value_original}};

+ if (UNLIKELY(es.throwIfNeeded()))

+ return;

+ {% endif %}

{% if attribute.is_nullable %}

bool isNull = false;

{{attribute.cpp_type}} {{attribute.cpp_value}} = {{attribute.cpp_value_original}};