Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects 10 tests.

BUG=639732
Review-Url: https://codereview.chromium.org/2678493002
Cr-Commit-Position: refs/heads/master@{#449390}
Committed: https://chromium.googlesource.com/chromium/src/+/6d7338d05ae5eb0503c83dc08f66afb5647eb680

[zakerinasab, 2017-02-03 17:38:06]

Description was changed from

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects 10 tests.

BUG=639732
==========

to

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects 10 tests.

BUG=639732
==========

[zakerinasab, 2017-02-03 17:38:07]

zakerinasab@chromium.org changed reviewers:
+ junov@chromium.org

[zakerinasab, 2017-02-03 17:38:27]

CL uploaded. PTAL.

[Justin Novosad, 2017-02-06 20:04:24]

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-ellipse-zero-lineto.html
(right):

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-ellipse-zero-lineto.html:8:
var canvas = document.getElementById('mycanvas');
indent

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillPath-alpha-shadow.html
(right):

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillPath-alpha-shadow.html:7:
var canvas = document.createElement('canvas');
indent

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillPath-alpha-shadow.html:48:
function test(x, y, r, g, b, a, alphaApprox) {
call this something else. It has a name conflict with the test() of
testharness.js

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillPath-alpha-shadow.html:64:
test(400, 150, 0, 0, 0, 0, 0);
Should use generate_tests() here

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillPath-gradient-shadow.html
(right):

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillPath-gradient-shadow.html:7:
var canvas = document.createElement('canvas');
indent

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillPath-pattern-shadow.html
(right):

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillPath-pattern-shadow.html:7:
function print(message, color)
indent

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillPath-pattern-shadow.html:17:
function shouldBeAround(a, b)
Remove this.  We use assert_approx_equals now.

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillPath-pattern-shadow.html:83:
function test(x, y, r, g, b, a, alphaApprox) {
This is confusing because testharness.js also defines a function named 'test'.

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillPath-pattern-shadow.html:99:
test(400, 150, 0, 0, 0, 0, 0);
Could use generate_tests()

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-fillPath-shadow.html
(right):

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillPath-shadow.html:7: var
canvas = document.createElement('canvas');
indent

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillRect-gradient-shadow.html
(right):

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillRect-gradient-shadow.html:7:
var canvas = document.createElement('canvas');
indent

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-fillRect-shadow.html
(right):

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillRect-shadow.html:7: var
canvas = document.createElement('canvas');
indent

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-fillRect.html (right):

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillRect.html:7: var ctx =
document.createElement('canvas').getContext('2d');
indent

[zakerinasab, 2017-02-09 18:02:01]

Comments addressed. The repeated tests are replaced with generate_tests as much
as possible. PTAL.

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-ellipse-zero-lineto.html
(right):

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-ellipse-zero-lineto.html:8:
var canvas = document.getElementById('mycanvas');
On 2017/02/06 20:04:23, Justin Novosad wrote:
> indent

Done.

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillPath-alpha-shadow.html
(right):

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillPath-alpha-shadow.html:7:
var canvas = document.createElement('canvas');
On 2017/02/06 20:04:23, Justin Novosad wrote:
> indent

Done.

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillPath-alpha-shadow.html:48:
function test(x, y, r, g, b, a, alphaApprox) {
On 2017/02/06 20:04:23, Justin Novosad wrote:
> call this something else. It has a name conflict with the test() of
> testharness.js 

Done.

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillPath-alpha-shadow.html:64:
test(400, 150, 0, 0, 0, 0, 0);
On 2017/02/06 20:04:23, Justin Novosad wrote:
> Should use generate_tests() here

Done.

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillPath-gradient-shadow.html
(right):

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillPath-gradient-shadow.html:7:
var canvas = document.createElement('canvas');
On 2017/02/06 20:04:23, Justin Novosad wrote:
> indent

Done.

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillPath-pattern-shadow.html
(right):

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillPath-pattern-shadow.html:7:
function print(message, color)
On 2017/02/06 20:04:23, Justin Novosad wrote:
> indent

Done.

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillPath-pattern-shadow.html:17:
function shouldBeAround(a, b)
On 2017/02/06 20:04:23, Justin Novosad wrote:
> Remove this.  We use assert_approx_equals now.

Done.

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillPath-pattern-shadow.html:83:
function test(x, y, r, g, b, a, alphaApprox) {
On 2017/02/06 20:04:23, Justin Novosad wrote:
> This is confusing because testharness.js also defines a function named 'test'.

Done.

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillPath-pattern-shadow.html:99:
test(400, 150, 0, 0, 0, 0, 0);
On 2017/02/06 20:04:23, Justin Novosad wrote:
> Could use generate_tests()

Done.

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-fillPath-shadow.html
(right):

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillPath-shadow.html:7: var
canvas = document.createElement('canvas');
On 2017/02/06 20:04:23, Justin Novosad wrote:
> indent

Done.

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillRect-gradient-shadow.html
(right):

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillRect-gradient-shadow.html:7:
var canvas = document.createElement('canvas');
On 2017/02/06 20:04:23, Justin Novosad wrote:
> indent

Done.

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-fillRect-shadow.html
(right):

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillRect-shadow.html:7: var
canvas = document.createElement('canvas');
On 2017/02/06 20:04:23, Justin Novosad wrote:
> indent

Done.

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-fillRect.html (right):

https://codereview.chromium.org/2678493002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillRect.html:7: var ctx =
document.createElement('canvas').getContext('2d');
On 2017/02/06 20:04:23, Justin Novosad wrote:
> indent

Done.

[Justin Novosad, 2017-02-09 19:45:40]

lgtm

[zakerinasab, 2017-02-09 19:47:07]

The CQ bit was checked by zakerinasab@chromium.org

[commit-bot: I haz the power, 2017-02-09 19:47:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 20:22:22]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486669627365500,
"parent_rev": "a599f3cce3cc1149ca1dd745153ac32bd4600574", "commit_rev":
"6d7338d05ae5eb0503c83dc08f66afb5647eb680"}

[commit-bot: I haz the power, 2017-02-09 20:22:56]

Description was changed from

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects 10 tests.

BUG=639732
==========

to

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects 10 tests.

BUG=639732

Review-Url: https://codereview.chromium.org/2678493002
Cr-Commit-Position: refs/heads/master@{#449390}
Committed:
https://chromium.googlesource.com/chromium/src/+/6d7338d05ae5eb0503c83dc08f66...
==========

[commit-bot: I haz the power, 2017-02-09 20:22:58]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6d7338d05ae5eb0503c83dc08f66...