Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 2678473002: [wrapper-tracing] For a worker, mark relative to its wrapper map. (Closed)

Created:
3 years, 10 months ago by Michael Lippautz
Modified:
3 years, 10 months ago
Reviewers:
haraken
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[wrapper-tracing] For a worker, mark relative to its wrapper map. If marking a ScriptWrappable's wrapper object in a worker context, do that by consulting the worker's underlying DOMWrapperMap. Store the worker world in TLS, as we cannot rely on the context of the isolate during marking as we might mark without a stack (and thus context). BUG=chromium:686563 patch from issue 2663643002 at patchset 140001 (http://crrev.com/2663643002#ps140001) Review-Url: https://codereview.chromium.org/2665733002 Cr-Commit-Position: refs/heads/master@{#447604} (cherry picked from commit ae599161857edda9ecbed70494c220f7f711600f) NOTRY=true NOPRESUBMIT=true TBR=haraken@chromium.org Review-Url: https://codereview.chromium.org/2678473002 Cr-Commit-Position: refs/branch-heads/2987@{#288} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/730c14f17cf3e89fbc1749abb053965cbc41f25a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -8 lines) Patch
A third_party/WebKit/LayoutTests/fast/workers/resources/worker-xhr-onerror.js View 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/workers/worker-gc-alive.html View 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp View 4 chunks +26 lines, -8 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2678473002/1
3 years, 10 months ago (2017-02-03 16:13:26 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-03 16:13:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2678473002/1
3 years, 10 months ago (2017-02-03 16:14:50 UTC) #9
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 10 months ago (2017-02-03 16:14:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2678473002/1
3 years, 10 months ago (2017-02-03 16:16:28 UTC) #14
haraken
LGTM
3 years, 10 months ago (2017-02-03 16:32:24 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 16:35:48 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/730c14f17cf3e89fbc1749abb053...

Powered by Google App Engine
This is Rietveld 408576698