Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 2678463003: Revert of Android: Add owned resources to android studio (Closed)

Created:
3 years, 10 months ago by agrieve
Modified:
3 years, 10 months ago
Reviewers:
estevenson, Peter Wen
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Android: Add owned resources to android studio (patchset #3 id:40001 of https://codereview.chromium.org/2667023002/ ) Reason for revert: Script now fails if resources aren't already built Original issue's description: > Android: Add owned resources to android studio > > Include owned resources and unzip owned resource zips in android studio > generated gradle projects. This allows a res directory to show up for > each project. > > BUG=682846 > > Review-Url: https://codereview.chromium.org/2667023002 > Cr-Commit-Position: refs/heads/master@{#447764} > Committed: https://chromium.googlesource.com/chromium/src/+/9af0deb4bd0d2eb6ec47063ce2a024641e0da52d TBR=estevenson@chromium.org,wnwen@chromium.org NOTRY=true BUG=682846, 688219 Review-Url: https://codereview.chromium.org/2678463003 Cr-Commit-Position: refs/heads/master@{#448195} Committed: https://chromium.googlesource.com/chromium/src/+/11f780768683d40c8a159698c321707a299dbf1c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -28 lines) Patch
M build/android/gradle/android.jinja View 1 chunk +0 lines, -5 lines 0 comments Download
M build/android/gradle/generate_gradle.py View 5 chunks +3 lines, -20 lines 0 comments Download
M docs/android_studio.md View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
agrieve
Created Revert of Android: Add owned resources to android studio
3 years, 10 months ago (2017-02-04 03:10:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2678463003/1
3 years, 10 months ago (2017-02-04 03:11:39 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 10 months ago (2017-02-04 05:12:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2678463003/1
3 years, 10 months ago (2017-02-05 23:37:44 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 00:36:20 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/11f780768683d40c8a159698c321...

Powered by Google App Engine
This is Rietveld 408576698