Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2678423004: Remove obsolete Cast extension IDs from various whitelists and files. (Closed)

Created:
3 years, 10 months ago by mark a. foltz
Modified:
3 years, 10 months ago
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chfremer+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, devtools-reviews_chromium.org, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, fukino+watch_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, mtomasz+watch_chromium.org, oka+watch_chromium.org, pfeldman+blink_chromium.org, posciak+watch_chromium.org, rginda+watch_chromium.org, telemetry-reviews_chromium.org, xjz+watch_chromium.org, yamaguchi+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete Cast extension IDs from various whitelists and files. List: * Cast Canary hfaagokkkhdbgiakmmlclaapfelnkoah B11A93E7E5B541F8010245EBDE2C74647D6C14B9 * Cast Staging fmfcbgogabcbclcofgocippekhfcmgfj FA01E0B81978950F2BC5A50512FD769725F57510 * Cast Beta dliochdbjfkdbacpmhlcpmleaejidimm F155646B5D1CA545F7E1E4E20D573DFDD44C2540 * Cast Stable boadgeojelhgndaghljhdicfkmllpafd 16CA7A47AAE4BE49B1E75A6B960C3875E945B264 * Old MRP Stable fjhoaacokmgbjemoflkofnenfaiekifl EF2AB692559EA97C3BBDEA018A8C45F92457BD4E * MRP Beta ekpaaapppgpmolpcldedioblbkmijaca C17CD9E6868D7B9C67926E0EC612EA25C768418F * MRP Staging lhkfccafpkdlaodkicmokbmfapjadkij A45DABDB47A31CC812E5490AB748C7D05E2D32E9 * MRP Canary ibiljbkambkbohapfhoonkcpcikdglop BFEE2E3B80BE21A645E63E9346DFC383E7CB3BDA BUG=636154 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2678423004 Cr-Commit-Position: refs/heads/master@{#449811} Committed: https://chromium.googlesource.com/chromium/src/+/7682c4d0bc1f5ccde371417af4bf96e64a94f4ed

Patch Set 1 #

Patch Set 2 : Fix tab_capture_api.cc #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -159 lines) Patch
M chrome/browser/extensions/api/tab_capture/tab_capture_api.cc View 1 3 chunks +2 lines, -23 lines 0 comments Download
M chrome/browser/media/webrtc/media_capture_devices_dispatcher.cc View 1 chunk +2 lines, -12 lines 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 2 2 chunks +2 lines, -11 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 3 chunks +8 lines, -27 lines 0 comments Download
M extensions/browser/guest_view/extension_view/whitelist/extension_view_whitelist.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M extensions/common/api/_api_features.json View 2 chunks +4 lines, -10 lines 0 comments Download
M extensions/common/api/_behavior_features.json View 1 chunk +1 line, -8 lines 0 comments Download
M extensions/common/api/_permission_features.json View 4 chunks +6 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js View 2 chunks +0 lines, -25 lines 0 comments Download
M tools/perf/profile_creators/extension_set.csv View 1 chunk +0 lines, -1 line 0 comments Download
M ui/file_manager/audio_player/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/video_player/js/cast/cast_extension_discoverer.js View 2 chunks +5 lines, -7 lines 0 comments Download
M ui/file_manager/video_player/manifest.json View 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 29 (17 generated)
mark a. foltz
PTAL sergeyu@: chrome/browser/media/webrtc miu@: chrome/browser/extensions/api/tab_capture zhenw@: tools/perf/profile_creators rockot@: */extensions/* yoshiki@: ui/file_manager brettw@: extensions/browser/guest_view/extension_view/whitelist caseq@: third_party/WebKit/Source/devtools/front_end
3 years, 10 months ago (2017-02-08 05:57:04 UTC) #9
pfeldman
third_party/WebKit/Source/devtools/front_end lgtm
3 years, 10 months ago (2017-02-08 06:02:26 UTC) #10
yoshiki
ui/file_manager lgtm
3 years, 10 months ago (2017-02-08 17:23:30 UTC) #13
Ken Rockot(use gerrit already)
lgtm
3 years, 10 months ago (2017-02-08 17:34:32 UTC) #15
brettw
lgtm
3 years, 10 months ago (2017-02-08 17:41:11 UTC) #16
Sergey Ulanov
lgtm
3 years, 10 months ago (2017-02-08 18:46:29 UTC) #17
miu
chrome/browser/extensions/api/tab_capture lgtm
3 years, 10 months ago (2017-02-09 22:00:02 UTC) #18
Zhen Wang
tools/perf/ lgtm
3 years, 10 months ago (2017-02-10 21:05:00 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2678423004/20001
3 years, 10 months ago (2017-02-10 22:05:22 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: closure_compilation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compilation/builds/6168) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 10 months ago (2017-02-10 22:09:29 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2678423004/40001
3 years, 10 months ago (2017-02-10 22:45:53 UTC) #26
commit-bot: I haz the power
3 years, 10 months ago (2017-02-11 01:01:14 UTC) #29
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7682c4d0bc1f5ccde371417af4bf...

Powered by Google App Engine
This is Rietveld 408576698