Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issue 2678373003: [DeviceService] Move PowerMonitor interfaces, client lib, impl to live in Device Service (Closed)

Created:
3 years, 10 months ago by leonhsl(Using Gerrit)
Modified:
3 years, 10 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DeviceService] Move PowerMonitor interfaces, client lib, impl to live in Device Service This CL moves all codes of //device/power_monitor to //services/device. BUG=689391 TEST=service_unittests TBR=tsepez@chromium.org Review-Url: https://codereview.chromium.org/2678373003 Cr-Commit-Position: refs/heads/master@{#449201} Committed: https://chromium.googlesource.com/chromium/src/+/1b4ee5cdef50a0cd1e039f8f83d3f070e2a7a81b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -531 lines) Patch
M content/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/child/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/child/child_thread_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M device/BUILD.gn View 2 chunks +0 lines, -5 lines 0 comments Download
D device/power_monitor/BUILD.gn View 1 chunk +0 lines, -24 lines 0 comments Download
D device/power_monitor/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D device/power_monitor/power_monitor_export.h View 1 chunk +0 lines, -29 lines 0 comments Download
D device/power_monitor/power_monitor_message_broadcaster.h View 1 chunk +0 lines, -43 lines 0 comments Download
D device/power_monitor/power_monitor_message_broadcaster.cc View 1 chunk +0 lines, -59 lines 0 comments Download
D device/power_monitor/power_monitor_message_broadcaster_unittest.cc View 1 chunk +0 lines, -111 lines 0 comments Download
D device/power_monitor/public/cpp/BUILD.gn View 1 chunk +0 lines, -22 lines 0 comments Download
D device/power_monitor/public/cpp/power_monitor_broadcast_source.h View 1 chunk +0 lines, -39 lines 0 comments Download
D device/power_monitor/public/cpp/power_monitor_broadcast_source.cc View 1 chunk +0 lines, -42 lines 0 comments Download
D device/power_monitor/public/cpp/power_monitor_broadcast_source_unittest.cc View 1 chunk +0 lines, -87 lines 0 comments Download
D device/power_monitor/public/interfaces/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download
D device/power_monitor/public/interfaces/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D device/power_monitor/public/interfaces/power_monitor.mojom View 1 chunk +0 lines, -22 lines 0 comments Download
M services/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M services/device/BUILD.gn View 2 chunks +19 lines, -1 line 0 comments Download
M services/device/device_service.h View 1 chunk +1 line, -1 line 0 comments Download
M services/device/device_service.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/device/power_monitor/BUILD.gn View 1 chunk +4 lines, -5 lines 0 comments Download
A + services/device/power_monitor/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/device/power_monitor/power_monitor_message_broadcaster.h View 2 chunks +6 lines, -8 lines 0 comments Download
A + services/device/power_monitor/power_monitor_message_broadcaster.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/device/power_monitor/power_monitor_message_broadcaster_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
A + services/device/public/cpp/power_monitor/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
A + services/device/public/cpp/power_monitor/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/device/public/cpp/power_monitor/power_monitor_broadcast_source.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + services/device/public/cpp/power_monitor/power_monitor_broadcast_source.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/device/public/cpp/power_monitor/power_monitor_broadcast_source_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M services/device/public/interfaces/BUILD.gn View 1 chunk +10 lines, -0 lines 0 comments Download
A + services/device/public/interfaces/power_monitor.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 24 (18 generated)
leonhsl(Using Gerrit)
Hi, would you PTAL at this? Thanks. rockot@: For overall review kinuko@: For OWNER review ...
3 years, 10 months ago (2017-02-08 09:26:17 UTC) #15
kinuko
content/ lgtm
3 years, 10 months ago (2017-02-08 15:14:10 UTC) #16
Ken Rockot(use gerrit already)
RS LGTM for mechanical move
3 years, 10 months ago (2017-02-08 23:01:12 UTC) #17
leonhsl(Using Gerrit)
Thanks all for review. Let me TBR Tom for the trivial change of mojom file: ...
3 years, 10 months ago (2017-02-09 02:37:11 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2678373003/20001
3 years, 10 months ago (2017-02-09 02:38:11 UTC) #21
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 04:37:40 UTC) #24
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1b4ee5cdef50a0cd1e039f8f83d3...

Powered by Google App Engine
This is Rietveld 408576698