Remove pre-MD code related to tray/menu user profiles.

Remove pre-MD code related to tray/menu user profiles.

TBR=derat@chromium.org
BUG=686294
Review-Url: https://codereview.chromium.org/2678353005
Cr-Commit-Position: refs/heads/master@{#449813}
Committed: https://chromium.googlesource.com/chromium/src/+/8822da076b4fa3a4e98bc2136309c449f4645a4c

[Evan Stade, 2017-02-08 01:55:21]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 01:55:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 01:59:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 01:59:58]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Evan Stade, 2017-02-08 17:43:39]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[Evan Stade, 2017-02-08 17:43:45]

estade@chromium.org changed reviewers:
+ tdanderson@chromium.org

[commit-bot: I haz the power, 2017-02-08 17:44:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 17:50:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 17:50:29]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tdanderson, 2017-02-08 22:33:41]

LGTM with a few comments + trybot failure addressed

https://codereview.chromium.org/2678353005/diff/40001/ash/common/system/user/...
File ash/common/system/user/button_from_view.cc (right):

https://codereview.chromium.org/2678353005/diff/40001/ash/common/system/user/...
ash/common/system/user/button_from_view.cc:22: #include "ui/views/background.h"
nit: should be able to remove this now

https://codereview.chromium.org/2678353005/diff/40001/ash/common/system/user/...
File ash/common/system/user/button_from_view.h (right):

https://codereview.chromium.org/2678353005/diff/40001/ash/common/system/user/...
ash/common/system/user/button_from_view.h:26: // pressed. If
|highlight_on_hover| is set to true, the button will be
nit: remove doc about |highlight_on_hover|

https://codereview.chromium.org/2678353005/diff/40001/ash/common/system/user/...
ash/common/system/user/button_from_view.h:64: bool button_hovered_;
Looks like you can remove this member too, and I think you'd want to keep the
OnMouse*() overrides as no-ops in this class to avoid inheriting any hover
effects from CustomButton.

https://codereview.chromium.org/2678353005/diff/40001/ash/common/system/user/...
File ash/common/system/user/user_card_view.cc (right):

https://codereview.chromium.org/2678353005/diff/40001/ash/common/system/user/...
ash/common/system/user/user_card_view.cc:301: if (!is_active_user()) {
nit: remove {}

[Evan Stade, 2017-02-09 17:40:07]

Description was changed from

==========
Remove pre-MD code related to tray/menu user profiles.

BUG=686294
==========

to

==========
Remove pre-MD code related to tray/menu user profiles.

Also adjust a11y name calculation (same result, less recursion).

BUG=686294
==========

[Evan Stade, 2017-02-09 17:45:07]

a couple of additional a11y related changes, ptal. You could add an
accessibility reviewer if you want, but I don't think it should be necessary as
it's easy* to verify it's WAI.

*Note, ChromeVox doesn't seem to work for my local build any more (due to
switching to ChromeVox Next?) and there are lots of errors in background.js when
I connect via remote debugging, however connecting via remote debugging also
allows me to see the axnodedata outputs as I tab around.

https://codereview.chromium.org/2678353005/diff/40001/ash/common/system/user/...
File ash/common/system/user/button_from_view.h (right):

https://codereview.chromium.org/2678353005/diff/40001/ash/common/system/user/...
ash/common/system/user/button_from_view.h:26: // pressed. If
|highlight_on_hover| is set to true, the button will be
On 2017/02/08 22:33:41, tdanderson wrote:
> nit: remove doc about |highlight_on_hover|

Done.

https://codereview.chromium.org/2678353005/diff/40001/ash/common/system/user/...
ash/common/system/user/button_from_view.h:64: bool button_hovered_;
On 2017/02/08 22:33:41, tdanderson wrote:
> Looks like you can remove this member too, and I think you'd want to keep the
> OnMouse*() overrides as no-ops in this class to avoid inheriting any hover
> effects from CustomButton.

used for tests

https://codereview.chromium.org/2678353005/diff/40001/ash/common/system/user/...
File ash/common/system/user/user_card_view.cc (right):

https://codereview.chromium.org/2678353005/diff/40001/ash/common/system/user/...
ash/common/system/user/user_card_view.cc:301: if (!is_active_user()) {
On 2017/02/08 22:33:41, tdanderson wrote:
> nit: remove {}

Done.

https://codereview.chromium.org/2678353005/diff/60001/ash/common/system/tray/...
File ash/common/system/tray/tray_utils.cc (left):

https://codereview.chromium.org/2678353005/diff/60001/ash/common/system/tray/...
ash/common/system/tray/tray_utils.cc:91:
GetAccessibleLabelFromDescendantViews(view->child_at(i), out_labels);
recursion really bothers me

https://codereview.chromium.org/2678353005/diff/60001/ash/common/system/user/...
File ash/common/system/user/user_card_view.cc (right):

https://codereview.chromium.org/2678353005/diff/60001/ash/common/system/user/...
ash/common/system/user/user_card_view.cc:336: // Construct the name by
concatenating descendants' names.
This logic exists because there are many different states this card can be in.

[Evan Stade, 2017-02-09 17:45:16]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 17:45:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 18:58:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 18:58:36]

Dry run: This issue passed the CQ dry run.

[tdanderson, 2017-02-10 15:53:18]

Can you please split the a11y changes into a separate cl? unless they are a
consequence of removing the non-md code and I'm missing something?

[Evan Stade, 2017-02-10 23:44:09]

Description was changed from

==========
Remove pre-MD code related to tray/menu user profiles.

Also adjust a11y name calculation (same result, less recursion).

BUG=686294
==========

to

==========
Remove pre-MD code related to tray/menu user profiles.

Also adjust a11y name calculation (same result, less recursion).

TBR=derat@chromium.org
BUG=686294
==========

[Evan Stade, 2017-02-10 23:44:09]

estade@chromium.org changed reviewers:
+ derat@chromium.org

[Evan Stade, 2017-02-10 23:44:25]

tbr derat@ for custom_frame_view_ash_unittest.cc

[Evan Stade, 2017-02-10 23:44:31]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-02-10 23:44:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdanderson@chromium.org
Link to the patchset: https://codereview.chromium.org/2678353005/#ps100001
(title: "back out a11y changes and rebase")

[Evan Stade, 2017-02-10 23:44:34]

The CQ bit was unchecked by estade@chromium.org

[Evan Stade, 2017-02-10 23:44:40]

Description was changed from

==========
Remove pre-MD code related to tray/menu user profiles.

Also adjust a11y name calculation (same result, less recursion).

TBR=derat@chromium.org
BUG=686294
==========

to

==========
Remove pre-MD code related to tray/menu user profiles.

TBR=derat@chromium.org
BUG=686294
==========

[Evan Stade, 2017-02-10 23:44:49]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2017-02-10 23:45:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniel Erat, 2017-02-11 00:04:46]

rubber-stamp lgtm for custom_frame_view_ash_unittest.cc

[commit-bot: I haz the power, 2017-02-11 01:11:07]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1486770289632200,
"parent_rev": "6e8bfa3991a15be001ac300469bc5e7c49e34d57", "commit_rev":
"8822da076b4fa3a4e98bc2136309c449f4645a4c"}

[commit-bot: I haz the power, 2017-02-11 01:12:23]

Description was changed from

==========
Remove pre-MD code related to tray/menu user profiles.

TBR=derat@chromium.org
BUG=686294
==========

to

==========
Remove pre-MD code related to tray/menu user profiles.

TBR=derat@chromium.org
BUG=686294

Review-Url: https://codereview.chromium.org/2678353005
Cr-Commit-Position: refs/heads/master@{#449813}
Committed:
https://chromium.googlesource.com/chromium/src/+/8822da076b4fa3a4e98bc2136309...
==========

[commit-bot: I haz the power, 2017-02-11 01:12:24]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/8822da076b4fa3a4e98bc2136309...