[raw_io] prevent output_text from returning `unicode` object.

[raw_io] prevent output_text from returning `unicode` object.

Because of python2's awkward handling of unicode, it's better to use
`str` and just "know" that it contains utf-8 encoded data. output_text
will still ensure that the returned data is valid utf-8 (by round-tripping
the original raw bytes with decode/encode), and so is different than
raw_io.output (which does no encoding/decoding whatsoever).

The only codepages which we've ever supported have been ASCII and UTF-8
anyway, and since ASCII is a strict subset of UTF-8, this is a reasonable
approach.

R=martiniss@chromium.org, nodir@chromium.org
BUG=689886
Review-Url: https://codereview.chromium.org/2678343010
Committed: https://github.com/luci/recipes-py/commit/0aa2b6364faf52b0536c37534efc4574708cecd6

[iannucci, 2017-02-08 22:26:02]

Description was changed from

==========
[raw_io] prevent output_text from returning `unicode` object.

Because of python2's awkward handling of unicode, it's better to use
`str` and just "know" that it contains utf-8 encoded data. output_text
will still ensure that the returned data is valid utf-8 (by round-tripping
the original raw bytes with decode/encode), and so is different than
raw_io.output (which does no encoding/decoding whatsoever).

The only codepages which we've ever supported have been ASCII and UTF-8
anyway, and since ASCII is a strict subset of UTF-8, this is a reasonable
approach.

R=martiniss@chromium.org, nodir@chromium.org
BUG=689886
==========

to

==========
[raw_io] prevent output_text from returning `unicode` object.

Because of python2's awkward handling of unicode, it's better to use
`str` and just "know" that it contains utf-8 encoded data. output_text
will still ensure that the returned data is valid utf-8 (by round-tripping
the original raw bytes with decode/encode), and so is different than
raw_io.output (which does no encoding/decoding whatsoever).

The only codepages which we've ever supported have been ASCII and UTF-8
anyway, and since ASCII is a strict subset of UTF-8, this is a reasonable
approach.

R=martiniss@chromium.org, nodir@chromium.org
BUG=689886
==========

[iannucci, 2017-02-08 22:26:02]

iannucci@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[iannucci, 2017-02-08 22:26:18]

On 2017/02/08 22:24:18, iannucci wrote:

+phajdan fyi

[nodir, 2017-02-08 22:27:12]

lgtm

[iannucci, 2017-02-08 22:31:27]

The CQ bit was checked by iannucci@chromium.org

[commit-bot: I haz the power, 2017-02-08 22:31:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 22:34:17]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486593087123020, "parent_rev":
"699e274630d839a4d49ac48744ad71216b9553c6", "commit_rev":
"0aa2b6364faf52b0536c37534efc4574708cecd6"}

[commit-bot: I haz the power, 2017-02-08 22:34:21]

Description was changed from

==========
[raw_io] prevent output_text from returning `unicode` object.

Because of python2's awkward handling of unicode, it's better to use
`str` and just "know" that it contains utf-8 encoded data. output_text
will still ensure that the returned data is valid utf-8 (by round-tripping
the original raw bytes with decode/encode), and so is different than
raw_io.output (which does no encoding/decoding whatsoever).

The only codepages which we've ever supported have been ASCII and UTF-8
anyway, and since ASCII is a strict subset of UTF-8, this is a reasonable
approach.

R=martiniss@chromium.org, nodir@chromium.org
BUG=689886
==========

to

==========
[raw_io] prevent output_text from returning `unicode` object.

Because of python2's awkward handling of unicode, it's better to use
`str` and just "know" that it contains utf-8 encoded data. output_text
will still ensure that the returned data is valid utf-8 (by round-tripping
the original raw bytes with decode/encode), and so is different than
raw_io.output (which does no encoding/decoding whatsoever).

The only codepages which we've ever supported have been ASCII and UTF-8
anyway, and since ASCII is a strict subset of UTF-8, this is a reasonable
approach.

R=martiniss@chromium.org, nodir@chromium.org
BUG=689886

Review-Url: https://codereview.chromium.org/2678343010
Committed:
https://github.com/luci/recipes-py/commit/0aa2b6364faf52b0536c37534efc4574708...
==========

[commit-bot: I haz the power, 2017-02-08 22:34:22]

Committed patchset #1 (id:1) as
https://github.com/luci/recipes-py/commit/0aa2b6364faf52b0536c37534efc4574708...