Modify DateComponents::parseTime to reject values with >3 fractional decimal places

input[type=time] and input[type=datetime-local] should not accept milliseconds with 4+ digits.

Modify DateComponents::parseTime to reject values with >3 fractional decimal places.
New behavior matches to the specification and Firefox behavor.

https://html.spec.whatwg.org/multipage/infrastructure.html#times

BUG=683041
Review-Url: https://codereview.chromium.org/2678343007
Cr-Commit-Position: refs/heads/master@{#449109}
Committed: https://chromium.googlesource.com/chromium/src/+/925b3122a05d1ecaeedc8780a05089de19a6990a

[tkent, 2017-02-08 10:24:07]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 10:24:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 12:14:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 12:14:59]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[PhistucK, 2017-02-08 12:44:20]

Thank you! Do not forget to add tests (Web Platform Tests are preferred).

[PhistucK, 2017-02-08 12:44:47]

phistuck@gmail.com changed reviewers:
+ phistuck@gmail.com

[Matt R, 2017-02-08 13:44:29]

On 2017/02/08 12:44:20, PhistucK wrote:
> Thank you! Do not forget to add tests (Web Platform Tests are preferred).

Whoops, yes, will add these ASAP.

[tkent, 2017-02-08 14:38:36]

Please "publish" this codereview.

On 2017/02/08 at 13:44:29, Matthieu.Rigolot wrote:
> On 2017/02/08 12:44:20, PhistucK wrote:
> > Thank you! Do not forget to add tests (Web Platform Tests are preferred).
> 
> Whoops, yes, will add these ASAP.

We already have tests for this behavior. As the red try bot boxes show, this
patch changes behavior of the following tests:
- external/wpt/html/semantics/forms/the-input-element/time-2.html
- fast/forms/datetimelocal/ValidityState-typeMismatch-datetimelocal.html
- fast/forms/time/time-validity-typemismatch.html
https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_r...

Please update test result, or update test itself.

[Matt R, 2017-02-08 16:18:11]

The CQ bit was checked by matthieu.rigolot@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 16:18:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 16:18:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 16:18:30]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[Matt R, 2017-02-08 16:20:34]

The CQ bit was checked by matthieu.rigolot@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 16:21:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 16:21:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 16:21:06]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[Matt R, 2017-02-08 16:23:12]

On 2017/02/08 14:38:36, tkent wrote:
> Please "publish" this codereview.
> 
> On 2017/02/08 at 13:44:29, Matthieu.Rigolot wrote:
> > On 2017/02/08 12:44:20, PhistucK wrote:
> > > Thank you! Do not forget to add tests (Web Platform Tests are preferred).
> > 
> > Whoops, yes, will add these ASAP.
> 
> We already have tests for this behavior. As the red try bot boxes show, this
> patch changes behavior of the following tests:
> - external/wpt/html/semantics/forms/the-input-element/time-2.html
> - fast/forms/datetimelocal/ValidityState-typeMismatch-datetimelocal.html
> - fast/forms/time/time-validity-typemismatch.html
>
https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_r...
> 
> Please update test result, or update test itself.

Thanks! Actually got that bit, sorry should have been more clear - hope i did it
correctly though. Tests updated

[tkent, 2017-02-08 19:45:57]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 19:47:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 21:47:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 21:47:05]

Dry run: This issue passed the CQ dry run.

[tkent, 2017-02-08 22:18:46]

lgtm.  Thank you for fixing this!

CL description:
--------------------------
Modify DateComponents::parseTime to reject values with >3 fractional decimal
places

BUG=683041
--------------------------

I prefer describing user-visible behavior change in the first paragraph.  I'll
change it to:

--------------------------
input[type=time] and input[type=datetime-local] should not accept milliseconds
with 4+ digits.

Modify DateComponents::parseTime to reject values with >3 fractional decimal
places.
New behavior matches to the specification and Firefox behavor.

https://html.spec.whatwg.org/multipage/infrastructure.html#times

BUG=683041
--------------------------

[tkent, 2017-02-08 22:19:07]

Description was changed from

==========
Modify DateComponents::parseTime to reject values with >3 fractional decimal
places

BUG=683041
==========

to

==========
input[type=time] and input[type=datetime-local] should not accept milliseconds
with 4+ digits.

Modify DateComponents::parseTime to reject values with >3 fractional decimal
places.
New behavior matches to the specification and Firefox behavor.

https://html.spec.whatwg.org/multipage/infrastructure.html#times

BUG=683041
==========

[tkent, 2017-02-08 22:19:08]

tkent@chromium.org changed reviewers:
+ matthieu.rigolot@gmail.com
- Matthieu.Rigolot@gmail.com

[tkent, 2017-02-08 22:19:37]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2017-02-08 22:20:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 22:26:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486592377662630,
"parent_rev": "9cb6cef367150495dc15eb0e20525752fe9e198e", "commit_rev":
"925b3122a05d1ecaeedc8780a05089de19a6990a"}

[commit-bot: I haz the power, 2017-02-08 22:26:45]

Description was changed from

==========
input[type=time] and input[type=datetime-local] should not accept milliseconds
with 4+ digits.

Modify DateComponents::parseTime to reject values with >3 fractional decimal
places.
New behavior matches to the specification and Firefox behavor.

https://html.spec.whatwg.org/multipage/infrastructure.html#times

BUG=683041
==========

to

==========
input[type=time] and input[type=datetime-local] should not accept milliseconds
with 4+ digits.

Modify DateComponents::parseTime to reject values with >3 fractional decimal
places.
New behavior matches to the specification and Firefox behavor.

https://html.spec.whatwg.org/multipage/infrastructure.html#times

BUG=683041

Review-Url: https://codereview.chromium.org/2678343007
Cr-Commit-Position: refs/heads/master@{#449109}
Committed:
https://chromium.googlesource.com/chromium/src/+/925b3122a05d1ecaeedc8780a050...
==========

[commit-bot: I haz the power, 2017-02-08 22:26:46]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/925b3122a05d1ecaeedc8780a050...

[Matt R, 2017-02-08 23:07:42]

On 2017/02/08 22:18:46, tkent wrote:
> lgtm.  Thank you for fixing this!
> 
> CL description:
> --------------------------
> Modify DateComponents::parseTime to reject values with >3 fractional decimal
> places
> 
> BUG=683041
> --------------------------
> 
> I prefer describing user-visible behavior change in the first paragraph.  I'll
> change it to:
> 
> --------------------------
> input[type=time] and input[type=datetime-local] should not accept milliseconds
> with 4+ digits.
> 
> Modify DateComponents::parseTime to reject values with >3 fractional decimal
> places.
> New behavior matches to the specification and Firefox behavor.
> 
> https://html.spec.whatwg.org/multipage/infrastructure.html#times
> 
> BUG=683041
> --------------------------

Happy to help! Thanks for the guidance on this