Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2678333003: Use base::STLClearObject in QuicServerInfo (Closed)

Created:
3 years, 10 months ago by xunjieli
Modified:
3 years, 10 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use base::STLClearObject in QuicServerInfo std::string::clear() doesn't guarantee to free memory. This CL uses base::STLClearObject() in QuicServerInfo. See linked bug for more info. BUG=689062 Review-Url: https://codereview.chromium.org/2678333003 Cr-Commit-Position: refs/heads/master@{#448983} Committed: https://chromium.googlesource.com/chromium/src/+/c3c226027ca052c366d9b425666ec4fe57aab22d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M net/quic/chromium/quic_server_info.cc View 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
xunjieli
3 years, 10 months ago (2017-02-07 22:20:39 UTC) #4
Ryan Hamilton
lgtm
3 years, 10 months ago (2017-02-07 23:18:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2678333003/1
3 years, 10 months ago (2017-02-08 13:59:26 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 14:05:17 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c3c226027ca052c366d9b425666e...

Powered by Google App Engine
This is Rietveld 408576698