[inspector] support for nested scheduled breaks

[inspector] support for nested scheduled breaks

In current implementation we don't support nested scheduled break at all. If one break was scheduled inside another and second one doesn't produce actual break (execution was in blackboxed code or no JavaScript was executed) then second one will clear first scheduled break even if any not blackboxed JavaScript will be executed later.

Ambiguous break reason is added for the case when we have more then one scheduled reason. "auxData" in this case contains object with array of { reason: reason, auxData: auxData } objects for each reason in 'reasons' property.  

BUG=chromium:632405
Review-Url: https://codereview.chromium.org/2678313002
Cr-Commit-Position: refs/heads/master@{#43021}
Committed: https://chromium.googlesource.com/v8/v8/+/56bf7dbdaf6cb413390d56f2e595d1fbaecc9b30

[kozy, 2017-02-07 16:31:32]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 16:31:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2017-02-07 16:34:17]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 16:34:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2017-02-07 16:44:50]

Description was changed from

==========
[inspector] support for nested scheduled breaks

BUG=chromium:632405
==========

to

==========
[inspector] support for nested scheduled breaks

In current implementation we don't support nested scheduled break at all. If one
break was scheduled inside another and second one doesn't produce actual break
(execution was in blackboxed code or no JavaScript was executed) then second one
will clear first scheduled break even if any not blackboxed JavaScript will be
executed later.

BUG=chromium:632405
==========

[kozy, 2017-02-07 16:44:50]

kozyatinskiy@chromium.org changed reviewers:
+ alph@chromium.org, pfeldman@chromium.org

[kozy, 2017-02-07 16:45:07]

Pavel and Alexey, please take a look!

[commit-bot: I haz the power, 2017-02-07 17:04:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 17:04:50]

Dry run: This issue passed the CQ dry run.

[pfeldman, 2017-02-07 19:01:06]

https://codereview.chromium.org/2678313002/diff/40001/src/inspector/v8-debugg...
File src/inspector/v8-debugger-agent-impl.cc (right):

https://codereview.chromium.org/2678313002/diff/40001/src/inspector/v8-debugg...
src/inspector/v8-debugger-agent-impl.cc:599: if (m_breakReason.empty()) return;
Is it not strict enough to put DCHECK here? So we are still lying in some cases?

https://codereview.chromium.org/2678313002/diff/40001/src/inspector/v8-debugg...
File src/inspector/v8-debugger-agent-impl.h (right):

https://codereview.chromium.org/2678313002/diff/40001/src/inspector/v8-debugg...
src/inspector/v8-debugger-agent-impl.h:195: std::vector<String16> m_breakReason;
typedef a pair for reason + auxdata

[kozy, 2017-02-07 22:54:20]

Description was changed from

==========
[inspector] support for nested scheduled breaks

In current implementation we don't support nested scheduled break at all. If one
break was scheduled inside another and second one doesn't produce actual break
(execution was in blackboxed code or no JavaScript was executed) then second one
will clear first scheduled break even if any not blackboxed JavaScript will be
executed later.

BUG=chromium:632405
==========

to

==========
[inspector] support for nested scheduled breaks

In current implementation we don't support nested scheduled break at all. If one
break was scheduled inside another and second one doesn't produce actual break
(execution was in blackboxed code or no JavaScript was executed) then second one
will clear first scheduled break even if any not blackboxed JavaScript will be
executed later.

Ambiguous break reason is added for the case when we have more then one
scheduled reason. "auxData" in this case contains object with array of { reason:
reason, auxData: auxData } objects for each reason in 'reasons' property.  

BUG=chromium:632405
==========

[kozy, 2017-02-07 22:54:36]

all done, please take another look.

https://codereview.chromium.org/2678313002/diff/40001/src/inspector/v8-debugg...
File src/inspector/v8-debugger-agent-impl.cc (right):

https://codereview.chromium.org/2678313002/diff/40001/src/inspector/v8-debugg...
src/inspector/v8-debugger-agent-impl.cc:599: if (m_breakReason.empty()) return;
On 2017/02/07 19:01:05, pfeldman wrote:
> Is it not strict enough to put DCHECK here? So we are still lying in some
cases?

We cleanup break reasons on actual break and we don't enforce everyone to call
cancelPauseOnNextStatement in our v8-inspector.h API.

https://codereview.chromium.org/2678313002/diff/40001/src/inspector/v8-debugg...
File src/inspector/v8-debugger-agent-impl.h (right):

https://codereview.chromium.org/2678313002/diff/40001/src/inspector/v8-debugg...
src/inspector/v8-debugger-agent-impl.h:195: std::vector<String16> m_breakReason;
On 2017/02/07 19:01:05, pfeldman wrote:
> typedef a pair for reason + auxdata

Done.

[pfeldman, 2017-02-07 23:22:29]

lgtm

[kozy, 2017-02-07 23:47:02]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 23:47:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2017-02-07 23:58:11]

The CQ bit was unchecked by kozyatinskiy@chromium.org

[kozy, 2017-02-07 23:58:21]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2017-02-07 23:58:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 01:09:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 01:09:16]

Try jobs failed on following builders:
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/22300)

[kozy, 2017-02-08 01:20:43]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2017-02-08 01:20:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 01:42:55]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1486516843154570,
"parent_rev": "4d7856d9ed3cc37042265ce57d0feb645625bbad", "commit_rev":
"56bf7dbdaf6cb413390d56f2e595d1fbaecc9b30"}

[commit-bot: I haz the power, 2017-02-08 01:43:00]

Description was changed from

==========
[inspector] support for nested scheduled breaks

In current implementation we don't support nested scheduled break at all. If one
break was scheduled inside another and second one doesn't produce actual break
(execution was in blackboxed code or no JavaScript was executed) then second one
will clear first scheduled break even if any not blackboxed JavaScript will be
executed later.

Ambiguous break reason is added for the case when we have more then one
scheduled reason. "auxData" in this case contains object with array of { reason:
reason, auxData: auxData } objects for each reason in 'reasons' property.  

BUG=chromium:632405
==========

to

==========
[inspector] support for nested scheduled breaks

In current implementation we don't support nested scheduled break at all. If one
break was scheduled inside another and second one doesn't produce actual break
(execution was in blackboxed code or no JavaScript was executed) then second one
will clear first scheduled break even if any not blackboxed JavaScript will be
executed later.

Ambiguous break reason is added for the case when we have more then one
scheduled reason. "auxData" in this case contains object with array of { reason:
reason, auxData: auxData } objects for each reason in 'reasons' property.  

BUG=chromium:632405

Review-Url: https://codereview.chromium.org/2678313002
Cr-Commit-Position: refs/heads/master@{#43021}
Committed:
https://chromium.googlesource.com/v8/v8/+/56bf7dbdaf6cb413390d56f2e595d1fbaec...
==========

[commit-bot: I haz the power, 2017-02-08 01:43:01]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/56bf7dbdaf6cb413390d56f2e595d1fbaec...